(Feature) No metamask initial prompt #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kOrLocked function Also, once the app starts, the metamask status is checked and then the app status is loaded
Now the initializeAppNoMetamaskOrLocked function is called synchronously
…kit-frontend into feature/noMetamaskPrompt # Conflicts: # src/components/marketplace/wallet_balance.tsx
|
Hi @chriskalani, please let me know if this is the expected behaviour. I'd uploaded a video above |
fvictorio
reviewed
Apr 5, 2019
…kit-frontend into feature/noMetamaskPrompt # Conflicts: # src/store/blockchain/actions.ts # src/store/market/actions.ts
unjapones
approved these changes
Apr 8, 2019
mariano-aguero
approved these changes
Apr 8, 2019
birimbau
pushed a commit
to birimbau/VeriDex
that referenced
this pull request
Jan 4, 2020
(Feature) No metamask initial prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222
Once you open the app, you will need to click on connect metamask to start using it (no matter if you have already gave permissions to the app)
Video demo