This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[instant] Update buy quote at start up in the case of default amount #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMillman19
changed the title
BMillman19
changed the title
| @@ -92,12 +92,11 @@ export class ZeroExInstantProvider extends React.Component<ZeroExInstantProvider | |||
| // tslint:disable-next-line:no-floating-promises | |||
| asyncData.fetchAvailableAssetDatasAndDispatchToStore(this._store); | |||
| } | |||
|
|
|||
| asyncData.fetchCurrentBuyQuoteAndDispatchToStore(this._store); | |||
There was a problem hiding this comment.
need the tslint:disable-next-line:no-floating-promises here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
buyQuoteUpdaterthat can be invoked to request a new quotebuyQuoteUpdateris now being used by the asyncData fetch we're doing on mount to kick off a quote request for the default amount passed into propsTesting instructions
This link will preselect REP and prefill instant with 20 units to buy
http://localhost:5000/?defaultSelectedAssetData=0xf47261b00000000000000000000000001985365e9f78359a9b6ad760e32412f4a445e862&defaultAssetBuyAmount=20
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.