This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
@0x/contracts-integrations: Add ChaiBridge and DydxBridge gas b…
#2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
force-pushed
the
feat/contracts/integrations/chai-bridge-benchmarks
branch
from
54a3dce
to
2e9d69c
Compare
dorothy-zbornak
force-pushed
the
feat/contracts/integrations/chai-bridge-benchmarks
branch
from
2e9d69c
to
cb7939e
Compare
moodlezoup
approved these changes
Feb 13, 2020
|
|
||
| import { contractAddresses } from '../mainnet_fork_utils'; | ||
|
|
||
| const CHONKY_DAI_WALLET = '0x3a9F7C8cA36C42d7035E87C3304eE5cBd353a532'; |
dorothy-zbornak
force-pushed
the
feat/contracts/dev-utils/dydx-validation
branch
from
c322ee2
to
3ec8924
Compare
`@0x/contracts-dev-utils`: Add `D18` library for working with base-10, 18-digit decimals. `@0x/contracts-dev-utils`: Use `D18` library instead of `LibFractions` in `LibDydxBalance`.
`@0x/dev-utils`: Fix all the weird dydx base unit madness.
…enchmark tests.
dorothy-zbornak
force-pushed
the
feat/contracts/integrations/chai-bridge-benchmarks
branch
from
cb7939e
to
cdd0dd2
Compare
dorothy-zbornak
requested review from
BMillman19,
dave4506,
dekz,
fabioberger,
feuGeneA,
fragosti and
xianny
as code owners
…st run gas costs to benchmarks.
dorothy-zbornak
force-pushed
the
feat/contracts/integrations/chai-bridge-benchmarks
branch
from
cdd0dd2
to
0baec61
Compare
dorothy-zbornak
changed the base branch from
feat/contracts/dev-utils/dydx-validation
to
development
dorothy-zbornak
deleted the
feat/contracts/integrations/chai-bridge-benchmarks
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing
DydxBridgeandChaiBridgegas benchmarking tests.Here's the results:
DydxBridgeDAI->USDC with 1 deposit and 1 withdraw action:375066DydxBridgeDAI->USDC with just 1 withdraw action:315896ChaiBridgeWETH->DAI:293453ChaiBridgeDAI->WETH:292936For reference:
124665Testing instructions
These are fork tests. Figure it out.
Types of changes
Checklist:
[WIP]if necessary.