Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

asset-swapper: RFQ-T firm quotes #2541

Merged
merged 36 commits into from
Apr 15, 2020
Merged

asset-swapper: RFQ-T firm quotes #2541

merged 36 commits into from
Apr 15, 2020

Commits on Apr 7, 2020

  1. prep asset-swapper: rename variable

    @feuGeneA
    feuGeneA committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    3cdccb7 View commit details
    Browse the repository at this point in the history

  2. asset-swapper: support firm RFQ-T quote requests

    @feuGeneA
    feuGeneA committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    403fb38 View commit details
    Browse the repository at this point in the history

  3. migrations: Deploy ERC20BridgeSampler

    @feuGeneA
    feuGeneA committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    343caa1 View commit details
    Browse the repository at this point in the history

  4. migrations: add yarn publish:private

    @feuGeneA
    feuGeneA committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    0e1572c View commit details
    Browse the repository at this point in the history

  5. asset-swapper, migrations: incl. prettier in lint

    @feuGeneA
    feuGeneA committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    4b5a02c View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. mk SwapQuoterOpt rfqtTakerApiKeyWhitelist optional 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5602aac View commit details
    Browse the repository at this point in the history

  2. Use NULL_ADDRESS instead of literal 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1670b21 View commit details
    Browse the repository at this point in the history

  3. Use map idiom instead of for loop 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    98fc780 View commit details
    Browse the repository at this point in the history

  4. Use Array.push instead of Array.concat 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    37390e0 View commit details
    Browse the repository at this point in the history

  5. Parallelize RFQ-T with orderbook query 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    aadcf8f View commit details
    Browse the repository at this point in the history

  6. Pass QuoteRequestor via SwapQuoteOpts not ctor arg 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    63bfd23 View commit details
    Browse the repository at this point in the history

  7. Use try...catch instead of Promise.catch() 

    Addresses review comments
#2541 (comment)
and
#2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    1 Configuration menu
    Copy the full SHA
    121d51b View commit details
    Browse the repository at this point in the history

  8. rm unused SwapQuoteRequestOpts key enableRfqt 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5f23833 View commit details
    Browse the repository at this point in the history

  9. Remove unused intentOnFilling method parameter 

    Addresses review comments
#2541 (comment)
and
#2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    227676c View commit details
    Browse the repository at this point in the history

  10. Push RFQ-T opts to own SwapQuoterOpts subnamespace 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    93872ad View commit details
    Browse the repository at this point in the history

  11. Demote instance member to just constructor a arg 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3c795d3 View commit details
    Browse the repository at this point in the history

  12. Demote public member to private 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    fa617d2 View commit details
    Browse the repository at this point in the history

  13. Push RFQ-T opts to SwapQuoterReqOpts subnamespace 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    70add44 View commit details
    Browse the repository at this point in the history

  14. Don't throw when RFQ-T client isn't whitelisted 

    Addresses review comments
#2541 (comment)
and
#2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5f4778c View commit details
    Browse the repository at this point in the history

  15. Promote max maker response time to a global option

    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    8cdc05f View commit details
    Browse the repository at this point in the history

  16. Promote a closure to a function 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    39c2a75 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Add yarn prettier script, & call it from lint

    @feuGeneA
    feuGeneA committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    eb5ec58 View commit details
    Browse the repository at this point in the history

  2. In Opts types, REQUIRE rfqt SUB-options 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    264407b View commit details
    Browse the repository at this point in the history

  3. Await Axios response so we don't circumvent catch 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    0cb5e45 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. asset-swapper: Mockable axios for QuoteRequestor (#2549) 

    * Mockable axios for QuoteRequestor

* Move RFQT Mocker to src

* move MockedRfqtFirmQuoteResponse into types file

* fix import
    Steve Klebanoff committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    84adbcb View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Eliminate unnecessary else 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    d55108a View commit details
    Browse the repository at this point in the history

  2. Type Axios response with undefined, not void 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    ccc9e18 View commit details
    Browse the repository at this point in the history

  3. Validate maker endpoint responses with JSON Schema 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    bb15f78 View commit details
    Browse the repository at this point in the history

  4. Clarify parallelization of orderbook & RFQT 

    Addresses review comment #2541 (comment)
    @feuGeneA
    feuGeneA committed Apr 13, 2020
    1 Configuration menu
    Copy the full SHA
    27ca75d View commit details
    Browse the repository at this point in the history

  5. Remove an unnecessary type annotation

    @feuGeneA
    feuGeneA committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    b854fcd View commit details
    Browse the repository at this point in the history

  6. Bug fix: RFQ-T orders werent going through sorting

    @feuGeneA
    feuGeneA committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    58d6256 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. RFQ-T: validate assetData & add more tests (#2552) 

    * test for returning a 200 with invalid data, and additonal logging for that case

* Ensure RFQ-T response has asset data we expect

* validate signed order schema

* give more descriptive variable names and test an unsigned order

* takeout unused var
    Steve Klebanoff committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    47ef7ff View commit details
    Browse the repository at this point in the history

  2. Fix bug: Stop ignoring default SwapQuoteRequestOps 

    SwapQuoter._getSwapQuoteAsync() was merging defaults into the options
sent into SwapQuoteCalculator.calculateMarket{Buy,Sell}SwapQuoteAsync(),
but it was using the unmerged options function parameter for the RFQ-T
options and also for the gas price option.
    @feuGeneA
    feuGeneA committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    aee758e View commit details
    Browse the repository at this point in the history

  3. Update {asset-s,migrat,contract-ad}* CHANGELOGs

    @feuGeneA
    feuGeneA committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    3bdfcb8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development' into rfq-t

    @feuGeneA
    feuGeneA committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    513ddb4 View commit details
    Browse the repository at this point in the history

  5. migrations: Add independent yarn prettier script

    @feuGeneA
    feuGeneA committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    1da8f68 View commit details
    Browse the repository at this point in the history