This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
fix: [asset-swapper] MultiHop edge cases #2730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
includedSources/excludedSources
can introduce a few edge cases.firstHopSource
is not present in theFillData
but it is required. No valid sources or reverts (didn't dig deep enough to confirm it was a revert)Sims on some pairs which use MultiHop often
Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.