This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
fix: [asset-swapper] excludedFeeSources. DODO Trade Allowed #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
requested review from
abandeali1,
hysz,
BMillman19 and
dave4506
as code owners
dekz
changed the title
dekz
force-pushed
the
fix/asset-swapper/fee-ganache
branch
from
c4b6544
to
a6d2b4a
Compare
dekz
force-pushed
the
fix/asset-swapper/fee-ganache
branch
from
a6d2b4a
to
b78475e
Compare
dorothy-zbornak
approved these changes
Oct 15, 2020
packages/asset-swapper/src/utils/market_operation_utils/index.ts
Outdated
Show resolved
Hide resolved
dekz
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2730
Enabled fee sources to be static and not result in Uniswap being excluded. Therefor we could likely get a maker/ETH taker/ETH price.
Unfortunately this means it is queried on Ganache tests and results in a revert.
I've added the ability to provide
excludedFeeSourcesso that they can be disabled in tests or environments where it doesn't exist.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.