Skip to content

Commit

Permalink
move to "Server >> Handling Fills"
Browse files Browse the repository at this point in the history
  • Loading branch information
xianny committed Apr 26, 2019
1 parent 5c3864a commit ec2739f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions v2/coordinator-specification.md
Expand Up @@ -166,8 +166,6 @@ When interacting with coordinator orders, the following Exchange methods must be
| [`batchCancelOrders`](https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#batchcancelorders) | No |
| [`cancelOrdersUpTo`](https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#cancelordersupto) | No |

Note: `matchOrders` is not currently implemented in [0x-coordinator-server](https://github.com/0xProject/0x-coordinator-server). The server will not generate approval signatures for a `matchOrders` request. However, the Coordinator contract still requires approval signatures for any `matchOrders` transactions. As such, `matchOrders` transactions must be executed directly through the Exchange contract.

`executeTransaction` will revert under the following conditions:

- The `tx.origin` (Ethereum transaction signer) differs from the passed in `txOrigin` parameter.
Expand Down Expand Up @@ -400,6 +398,8 @@ The coordinator server must maintain state in order to determine the validity of

## Handling fills

_Note: `matchOrders` is not currently implemented in [0x-coordinator-server](https://github.com/0xProject/0x-coordinator-server). The server will not generate approval signatures for a `matchOrders` request. However, the Coordinator contract still requires approval signatures for any `matchOrders` transactions. As such, `matchOrders` transactions must be executed directly through the Exchange contract._

Fill transaction requests should be rejected under the following conditions:

- The transaction is in any way invalid (incorrect formatting, signature, unsupported function, etc).
Expand Down

0 comments on commit ec2739f

Please sign in to comment.