This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
Connect wallet dialog redux #42
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import * as React from 'react'; | ||
import { connect } from 'react-redux'; | ||
import { Dispatch } from 'redux'; | ||
import { State } from 'ts/redux/reducer'; | ||
|
||
import { ConnectWalletDialog as ConnectWalletDialogComponent } from 'ts/components/dialogs/connect_wallet_dialog'; | ||
import { Dispatcher } from 'ts/redux/dispatcher'; | ||
|
||
interface ConnectWalletDialogProps {} | ||
|
||
// TODO(kimpers): add blockchain integration | ||
interface ConnectedState { | ||
isOpen: boolean; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More state to come here regarding the actual connection |
||
|
||
interface ConnectedDispatch { | ||
onDismiss: () => void; | ||
} | ||
|
||
const mapStateToProps = (state: State, _ownProps: ConnectWalletDialogProps): ConnectedState => ({ | ||
isOpen: state.isConnectWalletDialogOpen, | ||
}); | ||
|
||
const mapDispatchToProps = (dispatch: Dispatch<State>): ConnectedDispatch => { | ||
const dispatcher = new Dispatcher(dispatch); | ||
|
||
return { | ||
onDismiss: (): void => { | ||
dispatcher.updateIsConnectWalletDialogOpen(false); | ||
}, | ||
}; | ||
}; | ||
|
||
export const ConnectWalletDialog: React.ComponentClass<ConnectWalletDialogProps> = connect( | ||
mapStateToProps, | ||
mapDispatchToProps, | ||
)(ConnectWalletDialogComponent); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import * as React from 'react'; | ||
import { connect } from 'react-redux'; | ||
import { Dispatch } from 'redux'; | ||
import { State } from 'ts/redux/reducer'; | ||
|
||
import { Header as HeaderComponent } from 'ts/components/staking/header/header'; | ||
import { Dispatcher } from 'ts/redux/dispatcher'; | ||
|
||
interface HeaderProps { | ||
location?: Location; | ||
isNavToggled?: boolean; | ||
toggleMobileNav?: () => void; | ||
} | ||
|
||
interface ConnectedDispatch { | ||
onOpenConnectWalletDialog: () => void; | ||
} | ||
|
||
interface ConnectedState {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the future this will need to know if a wallet is connected for the indicator on the mobile menu |
||
|
||
// TODO(kimpers): Get connected wallet from state after connecting with blockchain | ||
const mapStateToProps = (_: State, _ownProps: HeaderProps): ConnectedState => ({}); | ||
|
||
const mapDispatchToProps = (dispatch: Dispatch<State>): ConnectedDispatch => { | ||
const dispatcher = new Dispatcher(dispatch); | ||
|
||
return { | ||
onOpenConnectWalletDialog: (): void => { | ||
dispatcher.updateIsConnectWalletDialogOpen(true); | ||
}, | ||
}; | ||
}; | ||
|
||
export const Header: React.ComponentClass<HeaderProps> = connect( | ||
mapStateToProps, | ||
mapDispatchToProps, | ||
)(HeaderComponent); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best place to put the dialog component but here it is ensured to always be mounted on a page where a "Connect Wallet" button can exist. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.