Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for constructor checker #377

Merged
merged 8 commits into from Jun 13, 2023
Merged

Add tests for constructor checker #377

merged 8 commits into from Jun 13, 2023

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Jun 12, 2023

Usage related changes

Development related changes

  • Introduces new test coverage for constructor checker

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Tests on constructor checker  starknet-hardhat-example#113
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

test/general-tests/constructor-test/check.ts Outdated Show resolved Hide resolved
test/general-tests/constructor-test/check.ts Outdated Show resolved Hide resolved
test/general-tests/constructor-test/check.ts Show resolved Hide resolved
test/general-tests/constructor-test/check.ts Outdated Show resolved Hide resolved
test/general-tests/constructor-test/check.ts Outdated Show resolved Hide resolved
test/general-tests/constructor-test/check.ts Outdated Show resolved Hide resolved
test/general-tests/constructor-test/check.ts Outdated Show resolved Hide resolved
test/general-tests/constructor-test/no_constructor.cairo Outdated Show resolved Hide resolved
@Nathan-SL Nathan-SL merged commit 3369a07 into master Jun 13, 2023
@Nathan-SL Nathan-SL deleted the constructor-checker branch June 13, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test constructor detection
2 participants