Add tests for constructor checker

scripts/test-setup.sh

@@ -6,7 +6,7 @@ trap 'for killable in $(jobs -p); do kill -9 $killable; done' EXIT
 
 # setup example repo
 rm -rf starknet-hardhat-example
-EXAMPLE_REPO_BRANCH="plugin"
+EXAMPLE_REPO_BRANCH="constructor-checker"
 if [[ "$CIRCLE_BRANCH" == "master" ]] && [[ "$EXAMPLE_REPO_BRANCH" != "plugin" ]]; then
     echo "Invalid example repo branch: $EXAMPLE_REPO_BRANCH"
     exit 1

test/general-tests/cairo0-constructor-test/check.ts

@@ -0,0 +1,8 @@
+import { hardhatStarknetCompileDeprecated, hardhatStarknetTest } from "../../utils/cli-functions";
+
+hardhatStarknetCompileDeprecated(
+    "contracts/contract.cairo contracts/simple_storage.cairo contracts/empty_constructor.cairo".split(
+        " "
+    )
+);
+hardhatStarknetTest("--no-compile test/cairo0-constructor.test.ts".split(" "));

test/general-tests/cairo0-constructor-test/hardhat.config.ts

@@ -0,0 +1,12 @@
+import "@shardlabs/starknet-hardhat-plugin";
+
+module.exports = {
+    starknet: {
+        network: "devnet"
+    },
+    networks: {
+        devnet: {
+            url: "http://127.0.0.1:5050"
+        }
+    }
+};

test/general-tests/cairo0-constructor-test/network.json

@@ -0,0 +1,4 @@
+{
+    "$schema": "../../network.schema",
+    "devnet": true
+}

test/general-tests/constructor-test/check.ts

@@ -1,8 +1,38 @@
-import { hardhatStarknetCompileDeprecated, hardhatStarknetTest } from "../../utils/cli-functions";
+import path from "path";
+import { hardhatStarknetCompile, hardhatStarknetTest } from "../../utils/cli-functions";
+import { copyFileSync } from "fs";
+import { assertContains, rmrfSync } from "../../utils/utils";
 
-hardhatStarknetCompileDeprecated(
-    "contracts/contract.cairo contracts/simple_storage.cairo contracts/empty_constructor.cairo".split(
-        " "
-    )
-);
+const prefix = path.join(__dirname);
+const sourcesPath = "cairo1-contracts";
+
+const duplicateConstructorContract = "duplicate_constructor.cairo";
+const contract1Path = path.join(sourcesPath, duplicateConstructorContract);
+
+const noConstructorContract = "no_constructor.cairo";
+const contract2Path = path.join(sourcesPath, noConstructorContract);
+
+const muteConstructorContract = "mute_constructor.cairo";
+const contract3Path = path.join(sourcesPath, muteConstructorContract);
+
+const commentedConstructorContract = "commented_constructor.cairo";
+const contract4Path = path.join(sourcesPath, commentedConstructorContract);
+
+const emptyLineConstructorContract = "empty_line_constructor.cairo";
+const contract5Path = path.join(sourcesPath, emptyLineConstructorContract);
+
+// Copy contracts to example repo to ensure files exists
+copyFileSync(path.join(prefix, duplicateConstructorContract), contract1Path);
+copyFileSync(path.join(prefix, noConstructorContract), contract2Path);
+copyFileSync(path.join(prefix, muteConstructorContract), contract3Path);
+copyFileSync(path.join(prefix, commentedConstructorContract), contract4Path);
+copyFileSync(path.join(prefix, emptyLineConstructorContract), contract5Path);
+
+const expectedErrorMsg = "Error: Expected at most one constructor.";
+const execution = hardhatStarknetCompile([contract1Path], true);
+assertContains(execution.stderr, expectedErrorMsg);
+rmrfSync(contract1Path);
+
+// Compile cairo1 contracts
+hardhatStarknetCompile(["cairo1-contracts/", "--add-pythonic-hints"]);
 hardhatStarknetTest("--no-compile test/constructor.test.ts".split(" "));

test/general-tests/constructor-test/commented_constructor.cairo

@@ -0,0 +1,8 @@
+#[contract]
+mod Contract {
+
+    #[constructor]
+    // comment
+    fn constructor() {
+    }
+}

test/general-tests/constructor-test/duplicate_constructor.cairo

@@ -0,0 +1,11 @@
+#[contract]
+mod Contract {
+
+    #[constructor]
+    fn constructor() {
+    }
+
+    #[constructor]
+    fn constructor2() {
+    }
+}

test/general-tests/constructor-test/empty_line_constructor.cairo

@@ -0,0 +1,9 @@
+#[contract]
+mod Contract {
+
+    #[constructor]
+
+
+    fn constructor() {
+    }
+}

test/general-tests/constructor-test/mute_constructor.cairo

@@ -0,0 +1,7 @@
+#[contract]
+mod Contract {
+
+    // #[constructor]
+    fn constructor() {
+    }
+}

test/general-tests/constructor-test/no_constructor.cairo

@@ -0,0 +1,12 @@
+#[contract]
+mod Contract {
+
+    struct Storage {
+        balance: felt252,
+    }
+
+    #[external]
+    fn increase_balance(amount1: felt252, amount2: felt252) {
+        balance::write(balance::read() + amount1 + amount2);
+    }
+}