This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Fixes from contract audit. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mint, added comments on xcert proof, removed string checks, eip165 moved into a standalone contract, minor fixes
Closed
fulldecent
suggested changes
May 3, 2018
contracts/protocol/Minter.sol
Outdated
| { | ||
| return XcertMintProxy(XCERT_MINT_PROXY_CONTRACT) | ||
| XcertMintProxy(XCERT_MINT_PROXY_CONTRACT) |
contracts/tokens/Xcert.sol
Outdated
| @@ -52,14 +54,11 @@ contract Xcert is Ownable, ERC721, ERC721Metadata, ERC165 { | |||
|
|
|||
| /* | |||
| * @dev Mapping from NFToken ID to proof. | |||
| * @notice token Proof has to exist for every token. | |||
There was a problem hiding this comment.
This is a tautology. Because of EVM, proof is automatically initialized to a zero-length list. Perhaps this was meant to say:
The Proof array for every token must include one or more items
fulldecent
approved these changes
May 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
owner override fix, assembly check in library, remove return true in mint, added comments on xcert proof, removed string checks, eip165 moved into a standalone contract, minor fixes..
@xpepermint @fulldecent