We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"semibrave" shows up 23 times in VexFlow.
All but one are private names that we can change.
However, MultimeasureRestRenderOptions contains a field semibrave_rest_glyph_scale that is part of the public API, and has been since version 1.2.88:
MultimeasureRestRenderOptions
semibrave_rest_glyph_scale
https://www.unpkg.com/browse/vexflow@1.2.88/src/multimeasurerest.js
Can we rename it to semibreve_rest_glyph_scale? :-) It would be a breaking change.
semibreve_rest_glyph_scale
The text was updated successfully, but these errors were encountered:
Let us not be semibrave but fully brave and make this change.
Sorry, something went wrong.
Yes, let's rename. (Especially if it'll stop @mscuthbert from making more terrible jokes!)
Just for that you get my gif illustrating how the semibreve rest put on weight over the centuries:
Successfully merging a pull request may close this issue.
"semibrave" shows up 23 times in VexFlow.
All but one are private names that we can change.
However,
MultimeasureRestRenderOptions
contains a fieldsemibrave_rest_glyph_scale
that is part of the public API, and has been since version 1.2.88:https://www.unpkg.com/browse/vexflow@1.2.88/src/multimeasurerest.js
Can we rename it to
semibreve_rest_glyph_scale
? :-) It would be a breaking change.The text was updated successfully, but these errors were encountered: