Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semibreve misspelled :-) #1147

Closed
ronyeh opened this issue Sep 22, 2021 · 3 comments · Fixed by #1159
Closed

Semibreve misspelled :-) #1147

ronyeh opened this issue Sep 22, 2021 · 3 comments · Fixed by #1159

Comments

@ronyeh
Copy link
Collaborator

ronyeh commented Sep 22, 2021

"semibrave" shows up 23 times in VexFlow.

All but one are private names that we can change.

However, MultimeasureRestRenderOptions contains a field semibrave_rest_glyph_scale that is part of the public API, and has been since version 1.2.88:

https://www.unpkg.com/browse/vexflow@1.2.88/src/multimeasurerest.js

Can we rename it to semibreve_rest_glyph_scale? :-) It would be a breaking change.
@mscuthbert
Copy link
Collaborator

Let us not be semibrave but fully brave and make this change.

@0xfe
Copy link
Owner

0xfe commented Sep 25, 2021

Yes, let's rename. (Especially if it'll stop @mscuthbert from making more terrible jokes!)

@mscuthbert
Copy link
Collaborator

Just for that you get my gif illustrating how the semibreve rest put on weight over the centuries:

semibreve_rests_get_fat

@h-sug1no h-sug1no mentioned this issue Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typo: semibrave to semibreve. h-sug1no/vexflow
3 participants
@ronyeh @0xfe @mscuthbert