Run prettier / eslint on the font data files, to improve consistency and editability of the files. #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
editability of the files. Roboto Slab and PetalumaScript are temporarily duplicated. The files named xxx_textmetrics.ts will be dropped in an upcoming PR. We are effectively renaming the files in two steps.
Closed
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extracted from my Fonts PR.
Most of the changes are just changes in the style of quotes, and adding commas. This way, we can edit these files in the future without introducing a huge diff.
Also in this PR
Roboto Slab and PetalumaScript font data files are temporarily duplicated. The files named
xxx_textmetrics.tswill be dropped in an upcoming PR, while the almost identical files namedxxx_glyphs.tswill be kept. We are effectively renaming the files in two steps, to avoid modifying any other source files in this PR. The files are namedxxx_glyphs.tsto mirror the naming scheme ofbravura_glyphs.ts,petaluma_glyphs.ts, etc, since their file structure is the same (other than the fact that they are missing the actual glyph outlines).