Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokensToSend Callback #25

Merged
merged 5 commits into from
Feb 24, 2018
Merged

Add tokensToSend Callback #25

merged 5 commits into from
Feb 24, 2018

Conversation

jbaylina
Copy link
Collaborator

@jbaylina jbaylina commented Feb 8, 2018 •
edited by 0xjac
Loading

I implemented the erc777_tokenHolder and changed the interface names following the eip820 suggestion.

@jacquesd edit: Closes #23

@jbaylina jbaylina mentioned this pull request Feb 19, 2018
Closed
@0xjac 0xjac self-assigned this Feb 23, 2018
@0xjac
Copy link
Owner

0xjac commented Feb 23, 2018

@jbaylina Looks all good, I will update the specs in here too (probably on the plane tomorrow) and merge.

@0xjac 0xjac mentioned this pull request Feb 23, 2018
Closed
@0xjac 0xjac changed the title Tokens to send Add tokensToSend Callback Feb 24, 2018
0xjac
0xjac previously approved these changes Feb 24, 2018
View reviewed changes
Copy link
Owner

@0xjac 0xjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good. We need more tests for this but since @jbaylina needs this urgently for EIP-820, I'll approve, merge now and add an issue to remind us to add more tests.

0xjac
0xjac reviewed Feb 24, 2018
View reviewed changes
Copy link
Owner

@0xjac 0xjac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good and I have squashed some commits. We need more tests for this but since @jbaylina needs this urgently for EIP-820, I'll approve, merge now and add an issue to remind us to add more tests.

0xjac
0xjac approved these changes Feb 24, 2018
View reviewed changes
Copy link
Owner

@0xjac 0xjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good and I have squashed some commits. We need more tests for this but since @jbaylina needs this urgently for EIP-820, I'll approve, merge now and add an issue to remind us to add more tests.

@0xjac 0xjac merged commit f256672 into master Feb 24, 2018
@0xjac 0xjac deleted the tokensToSend branch February 24, 2018 09:48
@0xjac 0xjac mentioned this pull request Feb 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjac 0xjac 0xjac approved these changes

Assignees

@0xjac 0xjac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbaylina @0xjac