fix(#94) - Create timeline component #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybridx
added
enhancement
hybridx
requested review from
sayak-sarkar and
riginoommen
and removed request for
a team
|
This pull request introduces 1 alert when merging 0ee344b into d74b113 - view on LGTM.com new alerts:
|
hybridx
commented
Sep 24, 2020
gisumit
requested changes
Sep 30, 2020
|
This pull request introduces 1 alert when merging a006f1e into 22da5a8 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0f0caf9 into 22da5a8 - view on LGTM.com new alerts:
|
gisumit
reviewed
Oct 27, 2020
gisumit
reviewed
Oct 27, 2020
gisumit
approved these changes
Oct 27, 2020
ghanlohar
suggested changes
Oct 27, 2020
ghanlohar
approved these changes
Oct 27, 2020
One Platform Development
automation
moved this from Review in progress
to Reviewer approved
Oct 27, 2020
diwanshi
requested changes
Oct 28, 2020
One Platform Development
automation
moved this from Reviewer approved
to Review in progress
Oct 28, 2020
fix(1-Platform#94) - Added stepper style APIs and event emitter fix(1-Platform#94) - Added line breaks
diwanshi
requested changes
Oct 29, 2020
packages/opc-timeline/README.md
Outdated
| - Sets the active state to the given number | ||
|
|
||
| ### variant | ||
| - Input: The following strings |
There was a problem hiding this comment.
remove this line. start from bullets for variant i.e default and compact. add sub-bullet to explain with text.
There was a problem hiding this comment.
Makes sense and made the changes
| if (this.variant === 'compact') { | ||
| return { | ||
| left: html` | ||
| <span class="timeline__arrow left" @click="${() => {this._scrollHandler('left')}}"> |
There was a problem hiding this comment.
we shouldn't name classes like this class="timeline__arrow left"
it should be class="timeline__arrow timeline__arrow--left" or class="timeline__arrow timeline__arrow--right"
One Platform Development
automation
moved this from Review in progress
to Reviewer approved
Oct 29, 2020
diwanshi
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94
Explain the feature/fix
Added basic for timeline component
Does this PR introduce a breaking change
No
Screenshots
Compact View Screenshot
Ready-for-merge Checklist
If it is a new component
Browsers you have tested in