Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the setup step in make livehtml for sphnix autobuild #118

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

inovizz
Copy link
Contributor

@inovizz inovizz commented Sep 20, 2021

Description

Fixing setup step in make livehtml, one of the argument -p is deprecated so changing it with the latest one --port

Motivation and Context

This helps fix the setup step.

Have you tested this? If so, how?

Yes, it works.

image

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 馃槃).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Issue

Resolves #115

Copy link
Member

@iamhssingh iamhssingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @inovizz

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #118 (28c451e) into master (75d06fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          20       20           
  Lines         649      649           
=======================================
  Hits          621      621           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 75d06fd...28c451e. Read the comment docs.

@iamhssingh
Copy link
Member

Closes #115

@iamhssingh iamhssingh merged commit 887a312 into 101Loop:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change --p to --port in make livehtml setup step in makefile
2 participants