Skip to content

Commit

Permalink
couple proxysite changes for comparison hopefully w/o side effects (m…
Browse files Browse the repository at this point in the history
…atomo-org#15570)

* Add comparison change to ViewDataTable as well.

* another comparison fix

* Undo change.

* remove some uses
  • Loading branch information
diosmosis authored and jonasgrilleres committed Sep 22, 2020
1 parent 703a9c4 commit c7443c4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 0 additions & 2 deletions core/Plugin/ViewDataTable.php
Expand Up @@ -15,8 +15,6 @@
use Piwik\Period;
use Piwik\Piwik;
use Piwik\Plugins\API\Filter\DataComparisonFilter;
use Piwik\Plugins\CoreVisualizations\Visualizations\Sparkline;
use Piwik\View;
use Piwik\View\ViewInterface;
use Piwik\ViewDataTable\Config as VizConfig;
use Piwik\ViewDataTable\Manager as ViewDataTableManager;
Expand Down
9 changes: 6 additions & 3 deletions core/Plugin/Visualization.php
Expand Up @@ -332,9 +332,12 @@ protected function loadDataTableFromAPI()

PluginManager::getInstance()->checkIsPluginActivated($module);

$proxyRequestParams = array_merge($request, [
'disable_root_datatable_post_processor' => 1,
]);
$proxyRequestParams = $request;
if ($this->isComparing()) {
$proxyRequestParams = array_merge($proxyRequestParams, [
'disable_root_datatable_post_processor' => 1,
]);
}

$class = ApiRequest::getClassNameAPI($module);
$dataTable = Proxy::getInstance()->call($class, $method, $proxyRequestParams);
Expand Down

0 comments on commit c7443c4

Please sign in to comment.