couple proxysite changes for comparison hopefully w/o side effects #15570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diosmosis feel free to merge if tests pass. We can always adjust demo later again as it's hard to test/know if it fully works |
|
ProxySite has tests but they don't work so well anymore, I can use those to get a better idea. |
|
Undid one part of the change, had to be fixed in ProxySite, will merge if tests pass. |
mattab
added
the
not-in-changelog
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
…atomo-org#15570) * Add comparison change to ViewDataTable as well. * another comparison fix * Undo change. * remove some uses
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
…atomo-org#15570) * Add comparison change to ViewDataTable as well. * another comparison fix * Undo change. * remove some uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15527
Not completely sure these changes are complete, but I don't get errors locally w/ comparison or get strange data.