[#221] [TECH] Utilisation d'un "subdir buildpack" pour séparer le déploiement des 3 applications #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out |
1 similar comment
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
1d8ee00
to
cc82452
Compare
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
cc82452
to
5da4894
Compare
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
5da4894
to
00d4abb
Compare
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
00d4abb
to
1f347d7
Compare
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
changed the title
jonathanperret
force-pushed
the
subdir-buildpack
branch
2 times, most recently
from
dad1d9e
to
31fe2e1
Compare
|
I'm deploying this PR to these urls:
Please check it out |
1 similar comment
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
changed the title
jbuget
reviewed
Oct 11, 2018
| @@ -0,0 +1,52 @@ | |||
| #!/bin/bash -e | |||
There was a problem hiding this comment.
Je ne comprends pas l'usage de ce fichier. C'est que pour les tests ?
There was a problem hiding this comment.
Oui, c’est un script qu’on peut lancer en local (à condition d’avoir Docker) pour tester le déploiement.
sroccaserra
approved these changes
Oct 16, 2018
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
31fe2e1
to
fda1144
Compare
|
I'm deploying this PR to these urls:
Please check it out |
|
Pour info, j'ai remanié le |
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
fda1144
to
d3cd929
Compare
|
I'm deploying this PR to these urls:
Please check it out |
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
d3cd929
to
7efe3e1
Compare
|
I'm deploying this PR to these urls:
Please check it out |
The following commands need to be run (adjusting the app names) to adjust
the Scalingo environment variables to deploy this correctly:
scalingo env-set -a pix-app-integration BUILDPACK_URL=https://github.com/1024pix/subdir-buildpack
scalingo env-set -a pix-app-integration BUILDPACK_SUBDIR=mon-pix
scalingo env-set -a pix-orga-integration BUILDPACK_URL=https://github.com/1024pix/subdir-buildpack
scalingo env-set -a pix-orga-integration BUILDPACK_SUBDIR=orga
scalingo env-set -a pix-api-integration BUILDPACK_URL=https://github.com/1024pix/subdir-buildpack
scalingo env-set -a pix-api-integration BUILDPACK_SUBDIR=api
jonathanperret
force-pushed
the
subdir-buildpack
branch
from
7efe3e1
to
c0cc875
Compare
|
I'm deploying this PR to these urls:
Please check it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nous déployons sur Scalingo ce repo sur 3 applications différentes (
pix-app-*pour le répertoiremon-pix,pix-api-*pourapietpix-orga-*pourorga).Actuellement, le déploiement pour les trois applications commence à la racine du repo et on utilise la variable
APPLICATION_NAMEpour avoir un comportement différent selon l'application à déployer. En particulier on utilise les mêmes buildpacks (nodejsetnginx) pour les trois applications alors que par exemple, l'applicationapin'a pas besoin denginx. Et pour les applications utilisantnginxon se retrouve à devoir démarrernginxdepuis un script dupackage.json(cf. https://github.com/1024pix/pix/blob/31cdf4e/scripts/start_scalingo_nginx.sh) parce que c'est le buildpacknodejsqui a la main.Cette PR propose d'utiliser un buildpack (créé pour l'occasion, à partir de deux autres au fonctionnement quasiment approprié : https://github.com/1024pix/subdir-buildpack ) qui va permettre de traiter chacun des trois sous-répertoires (
api,mon-pixetorga) comme une application déployable isolément. Ainsi chaque application peut utiliser ses propres buildpacks sans interférer avec les autres.Note :
Pour pouvoir déployer ce changement il faudra mettre à jour quelques variables d'environnement sur les applications Scalingo. Voici les commandes à lancer pour mettre à jour les applications d'intégration :
Et pour la production :