[TECH] Correction du build CircleCI en forçant Chrome 72 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome 73 breaks headless tests on CircleCI (see puppeteer/puppeteer#3774). While it's being investigated, using an older image should get us running tests again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤷♀️ 🤷♂️ Besoin :
Faire de nouveau fonctionner les tests front sur CircleCI, qui ne démarrent plus depuis que l'image
circleci/node:10.15-browsersa été mise à jour (il y a 3 jours) pour inclure Chrome 73. Le problème a été rencontré par d'autres : puppeteer/puppeteer#3774 mais la solution n'est pas encore claire.👩💻 👨💻 Technique :
En attendant, on force CircleCI à utiliser une version plus ancienne de l'image (
10.15.1-browsersalors que la dernière est10.15.3-browsers) qui fournit Chrome 72 avec lequel les tests fonctionnent bien.C'est un peu dommage d'avoir à changer la version de Node pour changer la version de Chrome, et on pourrait contourner ça en construisant notre propre image, mais ça ne vaut pas vraiment le coup ici. De plus, en production on utilise actuellement Node 10.15.1 (spécifié par nos
package.json).