Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Afficher le score Pix calculé à la fin de la campagne flash (PIX-6720) #5465

Merged
merged 2 commits into from Jan 6, 2023
Merged

[FEATURE] Afficher le score Pix calculé à la fin de la campagne flash (PIX-6720) #5465

merged 2 commits into from Jan 6, 2023

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Jan 6, 2023 •
edited by Libouk

🎄 Problème

Actuellement le score Pix affiché à la fin de la campagne flash est calculé avec une règle de 3.

🎁 Proposition

Renvoyer le score Pix calculé depuis le endpoint assessment-result

  • Dans le modèle AssessmentResult, ajouter un champ flashPixScore
  • Dans le ParticipantResultRepository, après avoir lu la capacité estimée de l’utilisateur, calculer son score Pix
  • Stocker le score Pix calculé dans la propriété flashPixScore de l' AssessmentResult
  • Impacter le serializer pour ajouter le champ flashPixScore dans la payload du endpoint

Afficher le score à la place du pixCount en règle de 3 sur l'écran de fin campagne.

🌟 Remarques

N/A

🎅 Pour tester

Se connecter sur la RA et lancer la campagne flash avec le code FLASH1234.
Terminer la campagne et voir le score !

@pix-service
Copy link
Contributor

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@nlepage nlepage changed the base branch from dev to pix-6719-calculate-pix-score-by-inference January 6, 2023 10:59
@nlepage nlepage force-pushed the pix-6720-display-flash-pix-score-in-skill-review branch 2 times, most recently from fb8e4ae to 0dc7802 Compare January 6, 2023 13:21
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-6719-calculate-pix-score-by-inference branch from 4a9cd7d to e3b5bbe Compare January 6, 2023 13:23
Base automatically changed from pix-6719-calculate-pix-score-by-inference to dev January 6, 2023 13:31
@Libouk Libouk force-pushed the pix-6720-display-flash-pix-score-in-skill-review branch from 0dc7802 to 0cb2dc1 Compare January 6, 2023 14:02
@Libouk Libouk marked this pull request as ready for review January 6, 2023 14:12
Libouk and others added 2 commits January 6, 2023 14:57
@Libouk @nlepage @mcampourcy
✨ api: add flash Pix score to participation result
5dbd653 
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
Co-authored-by: Mireille Campourcy <mireille.campourcy@pix.fr>
@nlepage @mcampourcy @Libouk
♻️ api: Change fetchForFlashCampaigns signature to take assessmentId …
34e87ba 
…instead of assessment

Co-authored-by: Mireille Campourcy <mireille.campourcy@pix.fr>
Co-authored-by: Quentin Lebouc <quentin.lebouc@pix.fr>
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-6720-display-flash-pix-score-in-skill-review branch from 8a36e1a to 34e87ba Compare January 6, 2023 14:57
@pix-service-auto-merge pix-service-auto-merge merged commit 80167c2 into dev Jan 6, 2023
@pix-service-auto-merge pix-service-auto-merge deleted the pix-6720-display-flash-pix-score-in-skill-review branch January 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcampourcy mcampourcy mcampourcy approved these changes

@Libouk Libouk Libouk approved these changes

Assignees

@mcampourcy mcampourcy

@nlepage nlepage

@Libouk Libouk

Labels
cross-team Toutes les équipes de dev Func Review OK PO validated functionally the PR 🚀 Ready to Merge Tech Review OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nlepage @pix-service @mcampourcy @Libouk @pix-service-auto-merge