[FEATURE] Séparer les résultats Flash des Participant Results (PIX-6746). #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
Libouk
force-pushed
the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
from
839c58e
to
5efedcf
Compare
Libouk
force-pushed
the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
from
5efedcf
to
c1ad065
Compare
nlepage
changed the base branch from
dev
to
pix-6769-add-scor-e-by-skills-for-new-algo
nlepage
added
the
⚠️ PR Inheritance
nlepage
force-pushed
the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
from
c1ad065
to
477e21f
Compare
nlepage
force-pushed
the
pix-6769-add-scor-e-by-skills-for-new-algo
branch
from
37525dd
to
4abe896
Compare
api/lib/infrastructure/repositories/participant-result-repository.js
Outdated
Show resolved
Hide resolved
VincentHardouin
approved these changes
Jan 26, 2023
pix-service-auto-merge
force-pushed
the
pix-6769-add-scor-e-by-skills-for-new-algo
branch
from
4abe896
to
826b080
Compare
nlepage
force-pushed
the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
from
477e21f
to
c8fb81a
Compare
nlepage
force-pushed
the
pix-6769-add-scor-e-by-skills-for-new-algo
branch
from
826b080
to
4fd26d1
Compare
Base automatically changed from
pix-6769-add-scor-e-by-skills-for-new-algo
to
dev
January 26, 2023 09:11
nlepage
force-pushed
the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
from
c8fb81a
to
dda7702
Compare
nlepage
removed
the
⚠️ PR Inheritance
nlepage
approved these changes
Jan 26, 2023
pix-service-auto-merge
force-pushed
the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
from
dda7702
to
6f0f980
Compare
pix-service-auto-merge
deleted the
pix-6746-move-logic-from-participation-result-repo-to-usecase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥚 Problème
Lorsqu'on avait ajouté la remontée du score Pix dans le participant result pour l'afficher dans l'écran de fin de campagne, on avait jugé que trop de logique/intelligence se trouvait dans le repository et que notre ajout créait de la dette technique. On s'était donc dit qu'on repasserait sur ce repository quand on en aurait l'occasion et une vision plus claire.
🥣 Proposition
Sortir l'intelligence et la logique du repository vers un usecase nous semble trop compliqué et hétérogène par rapport aux traitements déjà réalisés dans ce repository. On souhaite donc isoler notre ajout du Pix Score et du niveau estimé dans une fonction privée.
🥛 Remarques
Nous avons cherché à mieux délimiter le code se rapportant au nouveau scoring.
🧈 Pour tester
C'est un refacto, les tests doivent toujours passer. L'affichage du score Pix en fin de campagne flash doit toujours fonctionner.