[FEATURE] Permettre la reconciliation d'un organization learner en fonction des paramètre de reconcialitaion prédéfini (PIX-12556) #9249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
3 times, most recently
from
a2a1fa5
to
fb04b8c
Compare
lionelB
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
from
6de193b
to
b0b0a8f
Compare
xav-car
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
2 times, most recently
from
78b8aea
to
b37b838
Compare
xav-car
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
5 times, most recently
from
9b7d8d9
to
cb652c9
Compare
machestla
reviewed
Jun 17, 2024
...escription/learner-management/infrastructure/repositories/organization-learner-repository.js
Outdated
Show resolved
Hide resolved
...src/prescription/learner-management/domain/usecases/reconcile-common-organization-learner.js
Outdated
Show resolved
Hide resolved
machestla
reviewed
Jun 17, 2024
| { key: 'reconcileField1', value: 'Nom apprenant' }, | ||
| { key: 'reconcileField2', value: 'catégorie' }, | ||
| { key: 'reconcileField3', value: 'Date de naissance' }, | ||
| ], |
There was a problem hiding this comment.
Remarque : Nous pourrions utiliser ici un Objet ReconciliationInfos qui serait un tableau clés/valeurs au lieux d'utiliser le deserializedPayload
There was a problem hiding this comment.
Je propose qu'on le note en dette technique pour avancer sur le sujet. Est ce que c'est ok ?
lionelB
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
2 times, most recently
from
483e10f
to
56c13d2
Compare
lionelB
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
xav-car
commented
Jun 20, 2024
...iption/learner-management/unit/domain/usecases/reconcile-common-organization-learner_test.js
Show resolved
Hide resolved
xav-car
commented
Jun 20, 2024
...iption/learner-management/unit/domain/usecases/reconcile-common-organization-learner_test.js
Outdated
Show resolved
Hide resolved
xav-car
commented
Jun 20, 2024
...iption/learner-management/unit/domain/usecases/reconcile-common-organization-learner_test.js
Show resolved
Hide resolved
xav-car
commented
Jun 20, 2024
...iption/learner-management/unit/domain/usecases/reconcile-common-organization-learner_test.js
Show resolved
Hide resolved
xav-car
commented
Jun 20, 2024
...iption/learner-management/unit/domain/usecases/reconcile-common-organization-learner_test.js
Outdated
Show resolved
Hide resolved
xav-car
commented
Jun 20, 2024
...s/prescription/learner-management/acceptance/application/organization-learners-route_test.js
Outdated
Show resolved
Hide resolved
lionelB
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
6 times, most recently
from
65b4a74
to
cecc0cd
Compare
|
Func ok avec Curl le user connecté admin-orga@example.net et bien réconcilié avec le learner décris par ses reconciliation field |
xav-car
added
Tech Review OK
Func Review OK
frinyvonnick
approved these changes
Jun 21, 2024
machestla
approved these changes
Jun 21, 2024
Co-authored-by: Lionel <160320+lionelB@users.noreply.github.com>
Co-authored-by: Lionel <160320+lionelB@users.noreply.github.com>
Co-authored-by: Lionel <160320+lionelB@users.noreply.github.com>
pix-service-auto-merge
force-pushed
the
pix-12556/add-reconcile-endpoint-common-import
branch
from
cecc0cd
to
ae6ba42
Compare
pix-service-auto-merge
deleted the
pix-12556/add-reconcile-endpoint-common-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Nous avons un import générique, mais nous n'avons aucun moyen de reconcilier un user à son bon apprenant sur une organisation donnée
🤖 Proposition
Ajouter un endpoint qui permet de réconcilier un utilisateur avec un apprenant d'une organisation
🌈 Remarques
RAS
💯 Pour tester
Ci au vert, le endpoint n'étant pas branché au Front, à moins de faire un CURL le test func ne pourra être fait dans cette PR