Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Duplication de la route d'ajout de candidat de certification (PIX-12977). #9287

Merged

Conversation

alexandrecoin
Copy link
Contributor

@alexandrecoin alexandrecoin commented Jun 17, 2024

🦄 Problème

Dans le cadre de la séparation Pix/Pix+, nous souhaitons remplacer le paramètre complementary-certification du payload d'ajout de candidat par subscription (Celui-ci pourra contenir désormais à la fois du CORE ou du COMPLEMENTARY)

Cependant, et afin de ne pas casser l’existant pour les partenaires de Pix en ce qui concerne l’ajout de candidat (et notamment du payload), nous avons fait le choix de dupliquer la route concernant l’ajout de candidaten remplaçant le paramètre complementary-certification par subscription.

🤖 Proposition

Duplication de la route d'ajout de candidat en session

🌈 Remarques

💯 Pour tester

Tests verts

Ajout d'un candidat via la requête cURL suivante (en attendant le ticket front):

TOKEN=$(curl 'https://api-pr9287.review.pix.fr/api/token' --data-raw 'grant_type=password&username=certif-pro@example.net&password=pix123&scope=pix-certif' | jq -r .access_token)
curl https://api-pr9287.review.pix.fr/api/sessions/7409/certification-candidate \
    -H "Authorization: Bearer $TOKEN" \
    -H "Content-Type: application/json" \
    -H "Accept-language: fr-fr" \
    -X POST \
    -d @./candidate.json | jq '.'

candidate.json est un fichier situé dans le dossier où votre requête est exécutée et contenant des informations de ce type :

{
  "data": {
    "type": "certification-candidates",
    "attributes": {
      "first-name": "titi",
      "last-name": "titi",
      "birth-city": null,
      "birth-country": "FRANCE",
      "email": "titi@titi.fr",
      "result-recipient-email": null,
      "external-id": null,
      "birthdate": "2000-01-01",
      "extra-time-percentage": null,
      "birth-insee-code": "75115",
      "birth-postal-code": null,
      "billing-mode": "FREE",
      "sex": "M",
      "subscription": {
        "id": 52,
        "label": "Certif complémentaire 1",
        "key": "CERTIF"
      }
    }
  }
}

Non régression : Ajout d'un candidat via la modale d'inscription dans pix-certif

@alexandrecoin alexandrecoin self-assigned this Jun 17, 2024
@alexandrecoin alexandrecoin changed the base branch from dev to pix-12213-certif-core-subscription-core-or-not-core June 17, 2024 10:52
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@alexandrecoin alexandrecoin changed the title [FEATURE] Duplication de la route d'ajout de candidat de certification [FEATURE] Duplication de la route d'ajout de candidat de certification (PIX-12977). Jun 18, 2024
@alexandrecoin alexandrecoin force-pushed the pix-12977-duplicate-route-for-candidate-enrolment branch from 8002e57 to 47909eb Compare June 18, 2024 08:37
@alexandrecoin alexandrecoin marked this pull request as ready for review June 18, 2024 09:18
@alexandrecoin alexandrecoin requested a review from a team as a code owner June 18, 2024 09:18
@alexandrecoin alexandrecoin marked this pull request as draft June 18, 2024 09:21
@alexandrecoin alexandrecoin removed the request for review from a team June 18, 2024 09:21
@alexandrecoin alexandrecoin marked this pull request as ready for review June 18, 2024 09:29
Copy link
Contributor

@aceol aceol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On pourrait rajouter un tag déprécié avec un peu d'info (dans le commit)

@aceol
Copy link
Contributor

aceol commented Jun 18, 2024

Revue func ok 👍

@alexandrecoin alexandrecoin force-pushed the pix-12977-duplicate-route-for-candidate-enrolment branch from c1acf19 to 8278ac8 Compare June 19, 2024 03:19
@aceol aceol force-pushed the pix-12213-certif-core-subscription-core-or-not-core branch from ec1ca15 to 0396948 Compare June 19, 2024 13:03
@matthieu-octo matthieu-octo force-pushed the pix-12213-certif-core-subscription-core-or-not-core branch from 0396948 to 57f6f7f Compare June 21, 2024 08:26
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-12213-certif-core-subscription-core-or-not-core branch from 57f6f7f to 0136d71 Compare June 24, 2024 07:24
Base automatically changed from pix-12213-certif-core-subscription-core-or-not-core to dev June 24, 2024 07:30
@alexandrecoin alexandrecoin force-pushed the pix-12977-duplicate-route-for-candidate-enrolment branch from 8278ac8 to 9074201 Compare June 24, 2024 09:19
this duplication comes with the change of a payload parameter
complementary-certification becomes subscription in order for Pix Core to be included
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-12977-duplicate-route-for-candidate-enrolment branch from 8a301e6 to 4177857 Compare June 24, 2024 12:19
@pix-service-auto-merge pix-service-auto-merge merged commit 724b619 into dev Jun 24, 2024
6 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-12977-duplicate-route-for-candidate-enrolment branch June 24, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants