-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Duplication de la route d'ajout de candidat de certification (PIX-12977). #9287
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-12977-duplicate-route-for-candidate-enrolment
Jun 24, 2024
Merged
[FEATURE] Duplication de la route d'ajout de candidat de certification (PIX-12977). #9287
pix-service-auto-merge
merged 3 commits into
dev
from
pix-12977-duplicate-route-for-candidate-enrolment
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
8002e57
to
47909eb
Compare
aceol
reviewed
Jun 18, 2024
api/src/certification/enrolment/application/certification-candidate-controller.js
Outdated
Show resolved
Hide resolved
aceol
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On pourrait rajouter un tag déprécié avec un peu d'info (dans le commit)
Revue func ok 👍 |
c1acf19
to
8278ac8
Compare
api/src/certification/enrolment/application/certification-candidate-route.js
Show resolved
Hide resolved
api/src/certification/enrolment/application/certification-candidate-route.js
Show resolved
Hide resolved
api/src/certification/enrolment/application/certification-candidate-controller.js
Show resolved
Hide resolved
P-Jeremy
approved these changes
Jun 19, 2024
ec1ca15
to
0396948
Compare
0396948
to
57f6f7f
Compare
57f6f7f
to
0136d71
Compare
Base automatically changed from
pix-12213-certif-core-subscription-core-or-not-core
to
dev
June 24, 2024 07:30
8278ac8
to
9074201
Compare
this duplication comes with the change of a payload parameter complementary-certification becomes subscription in order for Pix Core to be included
8a301e6
to
4177857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
certif-next-gen
Func Review OK
PO validated functionally the PR
🚀 Ready to Merge
team-certif
Tech Review OK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans le cadre de la séparation Pix/Pix+, nous souhaitons remplacer le paramètre
complementary-certification
du payload d'ajout de candidat parsubscription
(Celui-ci pourra contenir désormais à la fois duCORE
ou duCOMPLEMENTARY
)Cependant, et afin de ne pas casser l’existant pour les partenaires de Pix en ce qui concerne l’ajout de candidat (et notamment du payload), nous avons fait le choix de dupliquer la route concernant l’ajout de candidaten remplaçant le paramètre
complementary-certification
parsubscription
.🤖 Proposition
Duplication de la route d'ajout de candidat en session
🌈 Remarques
💯 Pour tester
Tests verts
Ajout d'un candidat via la requête cURL suivante (en attendant le ticket front):
Où
candidate.json
est un fichier situé dans le dossier où votre requête est exécutée et contenant des informations de ce type :Non régression : Ajout d'un candidat via la modale d'inscription dans pix-certif