[FEATURE] Affiche la date de suppression d'une campagne sur PixAdmin (13054). #9318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
|
✔️ func ok |
lionelB
reviewed
Jun 19, 2024
| @@ -30,7 +30,7 @@ describe('Integration | Repository | Campaign-Management', function () { | |||
| const result = await campaignManagementRepository.get(campaign.id); | |||
|
|
|||
| // then | |||
| expect(result).to.deep.equal({ | |||
There was a problem hiding this comment.
question : quelle est la différence avec include ?
There was a problem hiding this comment.
equal va casser si il y a une propriété en plus alors que include non :) Dans ce test, je ne voulais pas spécifier le deletedAt donc j'ai changé l'assertion pour un include.
frinyvonnick
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-13054-display-deleted-indicator-on-campaigns-in-admin
branch
from
e853624
to
39f670f
Compare
…nts method of CampaignManagementRepository
pix-service-auto-merge
force-pushed
the
pix-13054-display-deleted-indicator-on-campaigns-in-admin
branch
from
39f670f
to
492546d
Compare
pix-service-auto-merge
deleted the
pix-13054-display-deleted-indicator-on-campaigns-in-admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans le cadre de l'Epix "Suppression de campagnes" les campagnes vont pouvoir être supprimées. On soupçonne que cela va engendré des questions au support. On a donc besoin de rendre accessible cette information facilement via PixAdmin.
🤖 Proposition
Ajouter dans la section Campagnes d'une organisation une colonne dans le tableau qui stipule si la campagne est supprimée et à quelle date.
🌈 Remarques
💯 Pour tester