[TECH] Déplace YamlParsingError vers les erreurs partagées de src
#9584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaf
added
👀 Tech Review Needed
cross-team
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
yaf
changed the title
YamlParsingError vers les erreurs partagées de src
yaf
force-pushed
the
migrate-yaml-parsing-error-to-src
branch
3 times, most recently
from
f74b46e
to
515d760
Compare
alexandrecoin
approved these changes
Jul 19, 2024
yaf
force-pushed
the
migrate-yaml-parsing-error-to-src
branch
2 times, most recently
from
f7267af
to
7c0e59c
Compare
yaf
force-pushed
the
migrate-yaml-parsing-error-to-src
branch
from
7c0e59c
to
744be12
Compare
|
Lundi on devrait avoir un outil pour tester plus finement ce genre de cas, avec l'aide de Romain. Et on pourra réutiliser cet outil par la suite. |
dlahaye
approved these changes
Jul 19, 2024
yaf
force-pushed
the
migrate-yaml-parsing-error-to-src
branch
from
744be12
to
37512d2
Compare
pix-service-auto-merge
force-pushed
the
migrate-yaml-parsing-error-to-src
branch
from
37512d2
to
a2ca165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
cf https://github.com/1024pix/pix/blob/dev/docs/adr/0051-nouvelle-arborescence-api.md
🤖 Proposition
Déplacer
YamlParsingErrorverssrc/shared/domain/errors.js🌈 Remarques
💯 Pour tester