[TECH] Migrer la route PATCH /api/admin/admin-members/{id} (PIX-13515 ) #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from lib to src/team
EmmanuelleBonnemay
added
👀 Tech Review Needed
👀 Func Review Needed
cross-team
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
EmmanuelleBonnemay
changed the title
yaf
added
Func Review OK
AndreiaPena
reviewed
Jul 19, 2024
| const updateAdminMember = async function (request, h, dependencies = { adminMemberSerializer }) { | ||
| const id = request.params.id; | ||
| const { role } = await adminMemberSerializer.deserialize(request.payload); | ||
| const updatedAdminMember = await srcUsecases.updateAdminMember({ id, role }); |
There was a problem hiding this comment.
Suggested change
| const updatedAdminMember = await srcUsecases.updateAdminMember({ id, role }); | |
| const updatedAdminMember = await usecases.updateAdminMember({ id, role }); |
AndreiaPena
reviewed
Jul 19, 2024
AndreiaPena
approved these changes
Jul 19, 2024
to src/team
yaf
force-pushed
the
pix-13515-patch-admin-admin-members-id
branch
from
b001e7a
to
73333fa
Compare
yaf
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
la route PATCH /api/admin/admin-members/{id} est toujours dans lib
🤖 Proposition
Déplacer cette route dans src
🌈 Remarques
ras
💯 Pour tester