Added fixed PortIDs to all wrappers #109

moiflo033 · 2021-06-21T14:03:13Z

As was discussed in #99

I noticed that:

./uavcan/node/430.GetInfo.1.0.uavcan
./uavcan/node/434.GetTransportStatistics.0.1.uavcan
./uavcan/node/435.ExecuteCommand.1.0.uavcan
./uavcan/node/435.ExecuteCommand.1.1.uavcan
./uavcan/node/7509.Heartbeat.1.0.uavcan

Arent templated so i left those as is.

I also noticed that the wrappers for:
uavcan/node/port/*
are missing.

Added fixed port IDs for: - [x] ./uavcan/diagnostic/8184.Record.1.0.uavcan - [x] ./uavcan/diagnostic/8184.Record.1.1.uavcan - [x] ./uavcan/file/405.GetInfo.0.1.uavcan - [x] ./uavcan/file/405.GetInfo.0.2.uavcan - [x] ./uavcan/file/406.List.0.1.uavcan - [x] ./uavcan/file/406.List.0.2.uavcan - [x] ./uavcan/file/407.Modify.1.0.uavcan - [x] ./uavcan/file/407.Modify.1.1.uavcan - [x] ./uavcan/file/408.Read.1.0.uavcan - [x] ./uavcan/file/408.Read.1.1.uavcan - [x] ./uavcan/file/409.Write.1.0.uavcan - [x] ./uavcan/file/409.Write.1.1.uavcan - [x] ./uavcan/internet/udp/500.HandleIncomingPacket.0.1.uavcan - [x] ./uavcan/internet/udp/500.HandleIncomingPacket.0.2.uavcan - [x] ./uavcan/internet/udp/8174.OutgoingPacket.0.1.uavcan - [x] ./uavcan/internet/udp/8174.OutgoingPacket.0.2.uavcan - [x] ./uavcan/pnp/8165.NodeIDAllocationData.2.0.uavcan - [x] ./uavcan/pnp/8166.NodeIDAllocationData.1.0.uavcan - [x] ./uavcan/pnp/cluster/390.AppendEntries.1.0.uavcan - [x] ./uavcan/pnp/cluster/391.RequestVote.1.0.uavcan - [x] ./uavcan/pnp/cluster/8164.Discovery.1.0.uavcan - [x] ./uavcan/register/384.Access.1.0.uavcan - [x] ./uavcan/register/385.List.1.0.uavcan - [x] ./uavcan/time/510.GetSynchronizationMasterInfo.0.1.uavcan - [x] ./uavcan/time/7168.Synchronization.1.0.uavcan

github-actions · 2021-06-21T14:21:01Z

Memory usage change @ 8f574fd

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:nano33ble	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/UAVCAN-BMS-Subscribe flash	%	examples/UAVCAN-BMS-Subscribe RAM for global variables	%	examples/UAVCAN-Blink flash	%	examples/UAVCAN-Blink RAM for global variables	%	examples/UAVCAN-Heartbeat-Publish flash	%	examples/UAVCAN-Heartbeat-Publish RAM for global variables	%	examples/UAVCAN-Heartbeat-Subscribe flash	%	examples/UAVCAN-Heartbeat-Subscribe RAM for global variables	%	examples/UAVCAN-Service-Client flash	%	examples/UAVCAN-Service-Client RAM for global variables	%	examples/UAVCAN-Service-Server flash	%	examples/UAVCAN-Service-Server RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:envie_m7	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:nano33ble	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrvidor4000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/UAVCAN-BMS-Subscribe<br>flash,%,examples/UAVCAN-BMS-Subscribe<br>RAM for global variables,%,examples/UAVCAN-Blink<br>flash,%,examples/UAVCAN-Blink<br>RAM for global variables,%,examples/UAVCAN-Heartbeat-Publish<br>flash,%,examples/UAVCAN-Heartbeat-Publish<br>RAM for global variables,%,examples/UAVCAN-Heartbeat-Subscribe<br>flash,%,examples/UAVCAN-Heartbeat-Subscribe<br>RAM for global variables,%,examples/UAVCAN-Service-Client<br>flash,%,examples/UAVCAN-Service-Client<br>RAM for global variables,%,examples/UAVCAN-Service-Server<br>flash,%,examples/UAVCAN-Service-Server<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

aentinger · 2021-06-21T14:21:50Z

Actually

./uavcan/node/430.GetInfo.1.0.uavcan
./uavcan/node/434.GetTransportStatistics.0.1.uavcan
./uavcan/node/435.ExecuteCommand.1.0.uavcan
./uavcan/node/435.ExecuteCommand.1.1.uavcan
./uavcan/node/7509.Heartbeat.1.0.uavcan

do need to be rewritten to be template-configurable. Could you please add that to this PR?

I've forgotten whether uavcan/node/port/* has intentionally been left out or I just forgot about it. Just in case it could be added in a separate PR.

aentinger · 2021-06-21T14:22:06Z

This fixes #99.

Added fixed port IDs for: - ./uavcan/node/430.GetInfo.1.0.uavcan - ./uavcan/node/434.GetTransportStatistics.0.1.uavcan - ./uavcan/node/435.ExecuteCommand.1.0.uavcan - ./uavcan/node/435.ExecuteCommand.1.1.uavcan - ./uavcan/node/7509.Heartbeat.1.0.uavcan

moiflo033 · 2021-06-21T14:44:24Z

Done.
I noticed that following wrappers are missing in the uavcan/node/* namespace:

Healt_1_0.h
IOStatistics_0_1.h
Mode_1_0.h

Also ID_1_0.hpp has a duplicate in types.

codecov-commenter · 2021-06-21T15:24:48Z

Codecov Report

Merging #109 (997b4c7) into master (63e7546) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   85.64%   85.64%           
=======================================
  Files          17       17           
  Lines         641      641           
=======================================
  Hits          549      549           
  Misses         92       92

Impacted Files	Coverage Δ
src/wrappers/uavcan/node/ExecuteCommand_1_0.hpp	`100.00% <ø> (ø)`
src/wrappers/uavcan/node/Heartbeat_1_0.hpp	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e7546...997b4c7. Read the comment docs.

github-actions · 2021-06-21T15:49:16Z

Memory usage change @ 997b4c7

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:nano33ble	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/UAVCAN-BMS-Subscribe flash	%	examples/UAVCAN-BMS-Subscribe RAM for global variables	%	examples/UAVCAN-Blink flash	%	examples/UAVCAN-Blink RAM for global variables	%	examples/UAVCAN-Heartbeat-Publish flash	%	examples/UAVCAN-Heartbeat-Publish RAM for global variables	%	examples/UAVCAN-Heartbeat-Subscribe flash	%	examples/UAVCAN-Heartbeat-Subscribe RAM for global variables	%	examples/UAVCAN-Service-Client flash	%	examples/UAVCAN-Service-Client RAM for global variables	%	examples/UAVCAN-Service-Server flash	%	examples/UAVCAN-Service-Server RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:envie_m7	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:nano33ble	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrvidor4000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/UAVCAN-BMS-Subscribe<br>flash,%,examples/UAVCAN-BMS-Subscribe<br>RAM for global variables,%,examples/UAVCAN-Blink<br>flash,%,examples/UAVCAN-Blink<br>RAM for global variables,%,examples/UAVCAN-Heartbeat-Publish<br>flash,%,examples/UAVCAN-Heartbeat-Publish<br>RAM for global variables,%,examples/UAVCAN-Heartbeat-Subscribe<br>flash,%,examples/UAVCAN-Heartbeat-Subscribe<br>RAM for global variables,%,examples/UAVCAN-Service-Client<br>flash,%,examples/UAVCAN-Service-Client<br>RAM for global variables,%,examples/UAVCAN-Service-Server<br>flash,%,examples/UAVCAN-Service-Server<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

aentinger

Thank you @moiflo033 🚀

aentinger · 2021-06-22T04:08:26Z

Health_1_0.h and Mode_1_0.h are not strictly necessary, as they probably never fill form a stand-alone UAVCAN message. However, IOStatistics_0_1.h really should be there. I've created #111 for tracking this.

ID_1_0 is "double" in terms of type naming, but not in terms of DSDL content. Compare uavcan/node/port/ID.1.0 with uavcan/node/ID.1.0

moiflo033 · 2021-06-22T07:42:37Z

Sorry i wasn't clear enoug ID_1_0.hpp is present in wrappers and types.

aentinger · 2021-06-22T08:13:39Z

Oh my, that's a 🐛

moiflo033 and others added 2 commits June 21, 2021 15:58

Merge branch '107-systems:master' into master

8f574fd

aentinger mentioned this pull request Jun 21, 2021

Implement wrappers for uavcan/node/port/* #110

Closed

moiflo033 added 2 commits June 21, 2021 16:39

Merge remote-tracking branch 'origin/master'

85aa2ed

moiflo033 added 3 commits June 21, 2021 16:55

Fixed compilation errors.

b24a30d

Fixed compilation errors.

21ba5dd

Fixed compilation errors in test.

997b4c7

aentinger approved these changes Jun 22, 2021

View reviewed changes

aentinger merged commit ef25d69 into 107-systems:master Jun 22, 2021

aentinger mentioned this pull request Jul 2, 2021

Fix: Assign fixed port IDs for DSDL wrappers which have a fixed port ID assigned #99

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added fixed PortIDs to all wrappers #109

Added fixed PortIDs to all wrappers #109

moiflo033 commented Jun 21, 2021 •

edited

Loading

github-actions bot commented Jun 21, 2021

aentinger commented Jun 21, 2021

aentinger commented Jun 21, 2021

moiflo033 commented Jun 21, 2021

codecov-commenter commented Jun 21, 2021

github-actions bot commented Jun 21, 2021

aentinger left a comment

aentinger commented Jun 22, 2021

moiflo033 commented Jun 22, 2021

aentinger commented Jun 22, 2021

Added fixed PortIDs to all wrappers #109

Added fixed PortIDs to all wrappers #109

Conversation

moiflo033 commented Jun 21, 2021 • edited Loading

github-actions bot commented Jun 21, 2021

aentinger commented Jun 21, 2021

aentinger commented Jun 21, 2021

moiflo033 commented Jun 21, 2021

codecov-commenter commented Jun 21, 2021

Codecov Report

github-actions bot commented Jun 21, 2021

aentinger left a comment

Choose a reason for hiding this comment

aentinger commented Jun 22, 2021

moiflo033 commented Jun 22, 2021

aentinger commented Jun 22, 2021

moiflo033 commented Jun 21, 2021 •

edited

Loading