Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference implementations #138

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Add reference implementations #138

merged 2 commits into from
Jun 14, 2022

Conversation

not7cd
Copy link
Contributor

@not7cd not7cd commented Oct 4, 2021

These projects are fully featured and tested. In the next two weeks, they will be battle tested.
They were developed as part of rocketry project for my student association for EuRoC competition.

They might not be the best reference implementations, but I wasn't able to find anything else working here on github. They might not be up to the standards, but they work.

Thank you for enabling this project with your library.

@aentinger
Copy link
Member

Good Morning @not7cd 👋 ☕
I'm glad to read that you've been able to use this library for your EuRoc project. Maybe you want to present it in the UAVCAN forum?

Unfortunately your project do not contain sufficient functionality to be called a reference implementation, it misses the register functionality for dynamic configuration. I know the same is true for the GNSS and ToF node, but those codes are under my sphere of influence so I can always update them while the same can't be said for your code. My compromise would be to list them under a "See also" header, very similar it's been done here (OpenCyphal-Garage/platform_specific_components#16). Would that be acceptable to you?

@aentinger aentinger added topic: documentation Documentation for the project. type: enhancement PR to improve the project. labels Oct 5, 2021
These projects are fully featured and tested. In the next two weeks, they will be battle tested. 
They were developed as part of rocketry project for my student association for EuRoC competition.

They might not be the best reference implementations, but I wasn't able to find anything else working here on github. They might not be up to the standards, but they work.
@aentinger aentinger merged commit 63618b5 into 107-systems:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Documentation for the project. type: enhancement PR to improve the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants