Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting and evaluating a timeout allows to drop stale transfers from the transmit queue. #183

Merged
merged 6 commits into from
Dec 23, 2022
Merged

Setting and evaluating a timeout allows to drop stale transfers from the transmit queue. #183

merged 6 commits into from
Dec 23, 2022

Commits on Dec 22, 2022

  1. Implement timeout for transfers.

    @aentinger
    aentinger committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1b29f79 View commit details
    Browse the repository at this point in the history

  2. Default parameters suck in terms of maintainability.

    @aentinger
    aentinger committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    c99ae2b View commit details
    Browse the repository at this point in the history

  3. Instead of forward declarations, which are basically hidden global de… 

    …pendencies, take the honest route and pass the required function as a function pointer.
    @aentinger
    aentinger committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9fb10db View commit details
    Browse the repository at this point in the history

  4. Rename TransferTimestampFunc to CyphalMicrosFunc and extract to dedic… 

    …ated header Const.h
    @aentinger
    aentinger committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    943107b View commit details
    Browse the repository at this point in the history

  5. By storing the callback function as Node member variable the overall … 

    …API can be simplified.
    @aentinger
    aentinger committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b70eac4 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. The transfer-ID timeout is only meaningful for incoming transfers, no… 

    …t publishers.

See #183 (comment) .
    @aentinger
    aentinger committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    a644b9e View commit details
    Browse the repository at this point in the history