Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: always create port/List.1.0 publisher. #221

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

aentinger
Copy link
Member

If Publishers/Subscriptions/etc. are created as global static objects the order of initialisation is not clear. Hence it could happen that Publisher IDs are not probably registered.

If Publishers/Subscriptions/etc. are created as global static objects the order of initialisation is not clear. Hence it could happen that Publisher IDs are not probably registered.
@aentinger aentinger added topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project. labels Mar 28, 2023
@aentinger aentinger self-assigned this Mar 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (6487c9c) 83.15% compared to head (7f9b89f) 83.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files           6        6           
  Lines         736      736           
=======================================
  Hits          612      612           
  Misses        124      124           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Memory usage change @ 7f9b89f

Board flash % RAM for global variables %
rp2040:rp2040:rpipico 🔺 +3288 - +6176 +0.16 - +0.3 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OpenCyphal-Blink
flash
% examples/OpenCyphal-Blink
RAM for global variables
% examples/OpenCyphal-Heartbeat-Publisher
flash
% examples/OpenCyphal-Heartbeat-Publisher
RAM for global variables
% examples/OpenCyphal-Heartbeat-Subscriber
flash
% examples/OpenCyphal-Heartbeat-Subscriber
RAM for global variables
% examples/OpenCyphal-Service-Client
flash
% examples/OpenCyphal-Service-Client
RAM for global variables
% examples/OpenCyphal-Service-Server
flash
% examples/OpenCyphal-Service-Server
RAM for global variables
% examples/OpenCyphal-GNSS-Node
flash
% examples/OpenCyphal-GNSS-Node
RAM for global variables
% examples/OpenCyphal-ToF-Distance-Sensor-Node
flash
% examples/OpenCyphal-ToF-Distance-Sensor-Node
RAM for global variables
%
rp2040:rp2040:rpipico 3368 0.16 0 0.0 3360 0.16 0 0.0 6176 0.3 0 0.0 3376 0.16 0 0.0 3472 0.17 0 0.0 3360 0.16 0 0.0 3288 0.16 0 0.0
Click for full report CSV
Board,examples/OpenCyphal-Blink<br>flash,%,examples/OpenCyphal-Blink<br>RAM for global variables,%,examples/OpenCyphal-Heartbeat-Publisher<br>flash,%,examples/OpenCyphal-Heartbeat-Publisher<br>RAM for global variables,%,examples/OpenCyphal-Heartbeat-Subscriber<br>flash,%,examples/OpenCyphal-Heartbeat-Subscriber<br>RAM for global variables,%,examples/OpenCyphal-Service-Client<br>flash,%,examples/OpenCyphal-Service-Client<br>RAM for global variables,%,examples/OpenCyphal-Service-Server<br>flash,%,examples/OpenCyphal-Service-Server<br>RAM for global variables,%,examples/OpenCyphal-GNSS-Node<br>flash,%,examples/OpenCyphal-GNSS-Node<br>RAM for global variables,%,examples/OpenCyphal-ToF-Distance-Sensor-Node<br>flash,%,examples/OpenCyphal-ToF-Distance-Sensor-Node<br>RAM for global variables,%
rp2040:rp2040:rpipico,3368,0.16,0,0.0,3360,0.16,0,0.0,6176,0.3,0,0.0,3376,0.16,0,0.0,3472,0.17,0,0.0,3360,0.16,0,0.0,3288,0.16,0,0.0

@aentinger aentinger merged commit 9f73c6a into main Mar 28, 2023
@aentinger aentinger deleted the always-port-list branch March 28, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants