Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not automatically assume a MTU != CANARD_MTU_CAN_CLASSIC (8) is CAN_FD, do a dedicated check instead. #260

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

aentinger
Copy link
Member

No description provided.

@aentinger aentinger added topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project. labels Nov 8, 2023
@aentinger aentinger self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

github-actions bot commented Nov 8, 2023

Memory usage change @ 8aac9b0

Board flash % RAM for global variables %
arduino:renesas_portenta:portenta_c33 🔺 +8 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:minima 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
rp2040:rp2040:arduino_nano_connect 🔺 +8 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipico 🔺 +8 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/CAN/OpenCyphal-Blink
flash
% examples/CAN/OpenCyphal-Blink
RAM for global variables
% examples/CAN/OpenCyphal-Heartbeat-Publisher
flash
% examples/CAN/OpenCyphal-Heartbeat-Publisher
RAM for global variables
% examples/CAN/OpenCyphal-Heartbeat-Subscriber
flash
% examples/CAN/OpenCyphal-Heartbeat-Subscriber
RAM for global variables
% examples/CAN/OpenCyphal-Service-Client
flash
% examples/CAN/OpenCyphal-Service-Client
RAM for global variables
% examples/CAN/OpenCyphal-Service-Server
flash
% examples/CAN/OpenCyphal-Service-Server
RAM for global variables
%
arduino:renesas_portenta:portenta_c33 16 0.0 0 0.0 8 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 8 0.0 0 0.0
arduino:renesas_uno:minima 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
rp2040:rp2040:arduino_nano_connect 16 0.0 0 0.0 8 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
rp2040:rp2040:rpipico 16 0.0 0 0.0 8 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
Click for full report CSV
Board,examples/CAN/OpenCyphal-Blink<br>flash,%,examples/CAN/OpenCyphal-Blink<br>RAM for global variables,%,examples/CAN/OpenCyphal-Heartbeat-Publisher<br>flash,%,examples/CAN/OpenCyphal-Heartbeat-Publisher<br>RAM for global variables,%,examples/CAN/OpenCyphal-Heartbeat-Subscriber<br>flash,%,examples/CAN/OpenCyphal-Heartbeat-Subscriber<br>RAM for global variables,%,examples/CAN/OpenCyphal-Service-Client<br>flash,%,examples/CAN/OpenCyphal-Service-Client<br>RAM for global variables,%,examples/CAN/OpenCyphal-Service-Server<br>flash,%,examples/CAN/OpenCyphal-Service-Server<br>RAM for global variables,%
arduino:renesas_portenta:portenta_c33,16,0.0,0,0.0,8,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,8,0.0,0,0.0
arduino:renesas_uno:minima,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0
rp2040:rp2040:arduino_nano_connect,16,0.0,0,0.0,8,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0
rp2040:rp2040:rpipico,16,0.0,0,0.0,8,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0

@aentinger aentinger merged commit dd6a8b5 into main Nov 8, 2023
22 checks passed
@aentinger aentinger deleted the fix-can-mtu branch November 8, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant