Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic height on android new-arch #147

Merged
merged 2 commits into from
Jul 14, 2024
Merged

fix: dynamic height on android new-arch #147

merged 2 commits into from
Jul 14, 2024

Conversation

17Amir17
Copy link
Collaborator

@17Amir17 17Amir17 commented Jun 30, 2024 •
edited
Loading

On android new arch, changing the webview height causes the browser to reload.

A workaround for this is to change the webviews container height

Testing

  • Android old arch
  • Android new arch
  • IOS old arch
  • IOS new arch

17Amir17
17Amir17 commented Jul 14, 2024
View reviewed changes
Copy link
Collaborator Author

@17Amir17 17Amir17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test old/new archs on android/ios
cc: @GuySerfaty

@17Amir17 17Amir17 merged commit 11b0e7c into main Jul 14, 2024
6 checks passed
@17Amir17 17Amir17 deleted the dymanic-height-android-new-arch branch July 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@17Amir17