Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WordPress "tested up to" version 6.3 on trunk #126

Merged
merged 1 commit into from Sep 12, 2023

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR merges the WP "tested up to" version bump from #125 into the trunk branch to hopefully trigger the Readme Updater action and update directly on WP.org without needing a minor plugin release here on GitHub.

Closes #124.

How to test the Change

Changelog Entry

n/a

Credits

Props @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.2.0 milestone Sep 11, 2023
@jeffpaul jeffpaul self-assigned this Sep 11, 2023
@jeffpaul jeffpaul requested a review from a team as a code owner September 11, 2023 20:38
@jeffpaul jeffpaul changed the title Update/wp version on trunk Bump WordPress "tested up to" version 6.3 on trunk Sep 11, 2023
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on a code read through.

I'm presuming this means the plugin has been tested with 6.3 so haven't repeated the process.

@peterwilsoncc peterwilsoncc merged commit dc7a92d into trunk Sep 12, 2023
1 check passed
@peterwilsoncc peterwilsoncc deleted the update/wp-version branch September 12, 2023 04:48
@jeffpaul
Copy link
Member Author

Looks like this one didn't make it across to DOTORG, possibly something during the build step? https://github.com/10up/Ad-Refresh-Control/actions/runs/6155017917/job/16722073689. I do wonder with this action why we're bothering with building since we should just be looking for changes to trunk that are ONLY to the readme or assets and then pushing those across to DOTORG (which again shouldn't require a build)?

@peterwilsoncc
Copy link
Contributor

I do wonder with this action why we're bothering with building since we should just be looking for changes to trunk that are ONLY to the readme or assets and then pushing those across to DOTORG (which again shouldn't require a build)?

The action looks for changes to other files and presumes there have been other merges to trunk if they are altered.

I think failing to build would cause the action to fail due as it would appear files have been deleted. What I don't understand is why the built files are changing as the lock file should prevent that. The only thing I have been able to think of is that the node version may be different and resulting if different output.

@dkotter dkotter modified the milestones: 1.2.0, 1.1.3 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants