Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override the autosuggest selector, not just append to it #2168

Closed
johnbillion opened this issue Apr 14, 2021 · 1 comment · Fixed by #2181
Closed

Ability to override the autosuggest selector, not just append to it #2168

johnbillion opened this issue Apr 14, 2021 · 1 comment · Fixed by #2181
Assignees
Milestone

Comments

@johnbillion
Copy link

Is your enhancement related to a problem? Please describe.

We're using the autosuggest feature on a site. The autosuggest.js file that handles this contains a hardcoded list of selectors to target, with the epas.selector option appended to the end. We'd like to override this list of selectors completely because some pages contain a search input (input type="search") which should not be targeted for autosuggest because it is used for another purpose.

Describe the solution you'd like

I'd like another option added to the options which can be filtered with the ep_autosuggest_options filter which overrides the list of selectors completely for more fine grained control.

Maybe this option could be called selectors and if it's specified then it overrides the hardcoded list + selector.

@JakePT JakePT self-assigned this Apr 14, 2021
@fagianijunior
Copy link

fagianijunior commented Apr 14, 2021

Have You read this issue? It will help you.
#2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants