Remove duplicate "case 'description'" #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjinks
commented
Dec 19, 2021
Comment on lines
-1013
to
-1015
| case 'description': | ||
| $es_field_name = 'description.sortable'; | ||
| break; |
There was a problem hiding this comment.
Exactly the same code is on line 995.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes a duplicate
case 'description':fromElasticPress\Indexable\Term\Term::parse_orderby().Alternate Designs
N/A
Benefits
Dead code elimination.
Possible Drawbacks
N/A
Verification Process
Run the test suite locally.
Checklist:
Applicable Issues
N/A
Changelog Entry
Removed a duplicate
case 'description':fromElasticPress\Indexable\Term\Term::parse_orderby()