Opinionated changes to Features page copy and controls. #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tott
requested changes
Oct 24, 2023
| 'type' => 'checkbox', | ||
| 'default' => '0', | ||
| 'key' => 'trigger_ga_event', | ||
| 'help' => __( 'Enable to fire a gtag tracking event when an autosuggest result is clicked.', 'elasticpress' ), |
There was a problem hiding this comment.
Feels like this could just be "Fire a gtag tracking event when an autosuggest result is clicked."
| 'value' => 'any', | ||
| ], | ||
| ], | ||
| 'type' => 'radio', | ||
| ], | ||
| [ | ||
| 'default' => '1', | ||
| 'help' => __( 'When enabled, it will show the term count in the instant results widget.', 'elasticpress' ), | ||
| 'help' => __( 'Enable to show the number of matching results next to filter options.', 'elasticpress' ), |
There was a problem hiding this comment.
Could also be just "Show the number of matching results next to filter options."
| ], | ||
| ], | ||
| 'type' => 'radio', | ||
| ], | ||
| [ | ||
| 'default' => '0', | ||
| 'help' => __( 'Wrap search terms in HTML tags in results for custom styling. The wrapping HTML tag comes with the "ep-highlight" class for easy styling.' ), | ||
| 'help' => __( 'Enable to wrap search terms in HTML tags in results for custom styling. The wrapping HTML tag comes with the <code>ep-highlight</code> class for easy styling.' ), |
There was a problem hiding this comment.
Change to "Wrap search terms in HTML tags in results for custom styling. The wrapping HTML tag comes with the ep-highlight class for easy styling."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Changes all feature settings that were radio buttons with just Enabled/Disabled options into checkbox controls, with descriptive labels.
Also changes the labels and help text for consistency (help text is all phrased as directives now).
How to test the Change
Changelog Entry
Changed - Updated the labels of feature settings and options for consistency and clarity.
Credits
Props @JakePT
Checklist: