Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new filter for weighting options #3827

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR introduce new filter ep_weighting_options to modify the weighting dashboard options. Also, it adds optional chaining to check if key does not exist set the object to empty.

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.1.0 milestone Feb 6, 2024
@felipeelia
Copy link
Member

@burhandodhy before we merge this, do you mind checking the failing PHPUnit test?

@felipeelia felipeelia merged commit a890265 into develop Feb 23, 2024
12 of 14 checks passed
@felipeelia felipeelia deleted the introduce-new-filter-for-weighting-options branch February 23, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants