Update to support adding new files to distignore #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed excluded files not being deleted if newly added to .distignore or .gitattributes
|
@pascalknecht welcome to our GitHub Actions and thanks for the PR! We'll work to get this into and through review and respond with any questions or concerns then, otherwise this will get milestoned into an upcoming release. Thanks again! |
helen
reviewed
Mar 4, 2020
| @@ -54,7 +54,7 @@ if [[ -e "$GITHUB_WORKSPACE/.distignore" ]]; then | |||
| echo "ℹ︎ Using .distignore" | |||
| # Copy from current branch to /trunk, excluding dotorg assets | |||
| # The --delete flag will delete anything in destination that no longer exists in source | |||
| rsync -rc --exclude-from="$GITHUB_WORKSPACE/.distignore" "$GITHUB_WORKSPACE/" trunk/ --delete | |||
| rsync -rc --exclude-from="$GITHUB_WORKSPACE/.distignore" "$GITHUB_WORKSPACE/" trunk/ --delete --delete-excluded | |||
There was a problem hiding this comment.
I think --delete-excluded also encompasses --delete but I like that keeping both is clear that both things are going to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed excluded files not being deleted if newly added to .distignore or .gitattributes. Currently if I had commited any file by accident and added this file newly to .distignore it will not be deleted as the rsync does not delete them
Benefits
Allows developers to be sure all files are deleted when necessary.
Possible Drawbacks
I think there are none.
Checklist:
Changelog Entry