New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean orphaned adstxt post types #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few notes inline.
To answer your question from the issue, I think this is as good a place as any to look for orphan posts.
Thanks, @peterwilsoncc I've updated PR according to your feedback, please let me know if you find any other issues. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for following up.
I pushed a few minor coding standards and comment changes.
Testing notes:
- create ads file
- Edit ads file to ensure revision created
- delete option from database
- refresh ads editing page
- ensure new post created
- ensure old post is deleted
- save, create revision
- repeat for app-ads file.
Description of the Change
Clean orphaned posts while visiting the settings management screen so that the unreferenced post will not remain as published in the database.
Closes #93
How to test the Change
Changelog Entry
Credits
Props @sksaju, @peterwilsoncc.
Checklist: