Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handing. #249

Merged
merged 1 commit into from Jul 3, 2023
Merged

Improved error handing. #249

merged 1 commit into from Jul 3, 2023

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As reported in #243, Currently when we get any errors from TwitterOAuth PHP lib, it wont showing properly. This PR fix this issue and display proper error with keep status of failure.

image

Closes #243

How to test the Change

  1. Manually throw error in any of Twitter status update function OR Stop the internet connection
  2. Go to create a new post, Enable autoTweet on post, Publish post
  3. Verify error message recorded in Twitter status there with failure.
  4. Try Tweet Now functionality, and verify that it also properly save status with failure message.

Changelog Entry

Changed - Improved error handing.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 3, 2023
@iamdharmesh iamdharmesh added this to the 2.1.0 milestone Jul 3, 2023
Sidsector9
Sidsector9 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@iamdharmesh iamdharmesh merged commit 92df624 into develop Jul 3, 2023
11 of 12 checks passed
@iamdharmesh iamdharmesh deleted the fix/243 branch July 3, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Display proper error message for TwitterOAuthException.
2 participants
@iamdharmesh @Sidsector9