Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/278: add id to the default row #281

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix/278: add id to the default row #281

merged 1 commit into from
Jan 23, 2024

Conversation

Sidsector9
Copy link
Member

Description of the Change

The reordering was broken due to the empty id parameter for the default row. This PR fixes it.

Closes #278

How to test the Change

Please follow the steps provided in the issue.

Changelog Entry

Fixed - Broken Repeater component drag and drop reordering functionality

Credits

Props @ajmaurya99 @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 changed the title fix/278: add uuid to the default row fix/278: add id to the default row Jan 17, 2024
@Sidsector9 Sidsector9 self-assigned this Jan 17, 2024
Copy link

Size Change: +20 B (0%)

Total Size: 65.3 kB

Filename Size Change
dist/index.js 65.3 kB +20 B (0%)

compressed-size-action

Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-281

@fabiankaegy fabiankaegy merged commit c41f88e into develop Jan 23, 2024
4 of 6 checks passed
@fabiankaegy fabiankaegy deleted the fix/278 branch January 23, 2024 16:13
@tlovett1
Copy link
Member

@Sidsector9 this introduced a new bug. The first element of that array does not exists since it's using default.

@Sidsector9
Copy link
Member Author

@tlovett1 can you provide the steps to reproduce this issue? When you say the first element does not exist, does it mean in the DB?
I created 3 items, verified with the data stored in the block attributes in the DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeater component drag and drop reordering is Broken in WordPress 6.4
3 participants