upkeep: Add TS support for Optional component
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -122 B (0%) Total Size: 65.6 kB
|
Passing run #768 ↗︎
Details:
Review all test suite changes for PR #298 ↗︎ |
|||||||||||||||
fabiankaegy
reviewed
Mar 1, 2024
components/optional/index.ts
Outdated
| @@ -1,7 +1,15 @@ | |||
| import PropTypes from 'prop-types'; | |||
There was a problem hiding this comment.
I actually think that as part of converting something to TypeScript it makes sense to get rid of all the PropTypes stuff.
fabiankaegy
reviewed
Mar 1, 2024
components/optional/index.ts
Outdated
| export const Optional: React.FC<OptionalProps> = ({ | ||
| value, | ||
| children, | ||
| }): boolean | React.ReactNode => { |
There was a problem hiding this comment.
I'm not sure we need / want to explicitly type the return type of every function. If something can be inferred I would rather just leave it up to the compiler
Sidsector9
changed the title
Optional componentOptional component
Sidsector9
changed the title
Optional componentOptional component
fabiankaegy
reviewed
Mar 1, 2024
Co-authored-by: Fabian Kägy <mail@fabian-kaegy.de>
…ponents into upkeep/component-optional
fabiankaegy
reviewed
Mar 4, 2024
components/optional/index.ts
Outdated
Comment on lines
23
to
25
| Optional.defaultProps = { | ||
| value: '', | ||
| }; |
There was a problem hiding this comment.
This can be removed now that we have the default value inline
…ponents into upkeep/component-optional
fabiankaegy
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
Changelog Entry
Credits
Props @fabiankaegy @Sidsector9
Checklist: