Refactor ContentSearch to use react query
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Enhancement
|
Size Change: -642 B (-0.99%) Total Size: 64.5 kB
|
1 failed test on run #869 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| IconPicker > allows the user to use the post picker to change an icon and displays it |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #326 ↗︎
fabiankaegy
commented
Jun 6, 2024
|
🎉 A new testing version of this package has been published to NPM. You can install it with |
|
This work here includes improvements suggested in #221 |
4 tasks
# Conflicts: # components/content-search/SearchItem.tsx # components/content-search/index.tsx # package-lock.json # package.json
# Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR replaces the custom
useEffectbased data fetching with custom pagination & abort controller withreact-queryCloses #
How to test the Change
Changelog Entry
Credits
Props @fabiankaegy @johnwatkins0
Checklist: