Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E testing with Cypress #334

Merged
merged 27 commits into from
May 17, 2022
Merged

E2E testing with Cypress #334

merged 27 commits into from
May 17, 2022

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Apr 15, 2022

Description of the Change

This PR removes wpacceptance tests and Adds end-to-end testing with Cypress to follow OSBP guide. Test runs automatically on every pull request to the develop branch.

Steps to perform local testing or develop new tests:

  1. Install dependencies npm install
  2. Start wp-env local development suite npm run env:start
  3. Run cypress npm run cypress:run or open developer browser npm run cypress:open

Closes #333

Verification Process

GitHub Actions workflow "E2E test", expected to pass the test. Refer to "Description of the Change" for local testing.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - End-to-end testing with Cypress

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Apr 15, 2022
@iamdharmesh iamdharmesh added this to the 1.8.0 milestone Apr 15, 2022
@iamdharmesh iamdharmesh requested review from a team and faisal-alvi and removed request for a team May 9, 2022 13:33
@iamdharmesh iamdharmesh marked this pull request as ready for review May 9, 2022 13:33
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 great work @iamdharmesh, just asked a question + a super minor extra line issue + .gitignore conflict, please have a look.

.eslintrc.json Outdated Show resolved Hide resolved
tests/cypress/integration/language-processing.test.js Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamdharmesh
Copy link
Member Author

@jeffpaul please help to remove wpa GH action from the required list, as we already replaced it with cypress and its blocker for merging the PR.

Thanks.

@jeffpaul
Copy link
Member

@iamdharmesh done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Cypress for E2E testing
3 participants