Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors with the get_formatted_latest_response method #466

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented May 25, 2023

Description of the Change

In #403, some refactoring was done to the get_formatted_latest_response method. There was two problems introduced here though:

  1. This method forced all data passed in to be a string, though most of the time the data was pass in here is an array. This caused fatal errors on the site health screen
  2. For the OpenAI integrations, we were passing in the transient key but not the actual data, so the data we were outputting was not helpful

This PR fixes both of these issues.

Closes #463

How to test the Change

  1. Go to your Site Health screen
  2. Ensure this screen loads without any errors
  3. Open the ClassifAI panel and ensure data shows there

Changelog Entry

Fixed - Ensure we properly output data on the Site Health screen without causing errors

Credits

Props @dkotter, @hugosolar

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.2.1 milestone May 25, 2023
@dkotter dkotter self-assigned this May 25, 2023
@dkotter dkotter requested review from a team and jeffpaul as code owners May 25, 2023 21:02
@dkotter dkotter requested review from ravinderk and removed request for a team and jeffpaul May 25, 2023 21:02
@ravinderk ravinderk merged commit 1c78244 into develop May 26, 2023
13 checks passed
@ravinderk ravinderk deleted the fix/463 branch May 26, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error on Site health screen after updating to 2.2.0
2 participants