-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: multiple prompts #602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
6 tasks
jeffpaul
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravinderk some feedback from UAT today:
- update labels/text from "shrink content" / "grow content" to "Expand this text" / "Condense this text" (or "Expand"/"Condense") to better match the actual labels in the block editor
- Update [green] check mark iconss to be more obvious that they're for setting defaults (green check mark > "Default prompt", check mark > "Set as default prompt")
- Update trash can icons to be more obvious that they're for deleting prompts (trashcan > "Delete this prompt")
- Saving prompts only works if there's a title/body to the prompt, so will want to add in some handling for when a title or body is missing so that things can either be saved or throw an error message to ensure an admin fills out title and body to properly save a prompt
Done.
Done.
Done. I replaced
Done. cc @jeffpaul |
Use correct selector to select 'Add new prompt' button.
Use correct selctor for prompt form field action items.
…o save those but only use them if nothing custom is added. Remove the required attribute from the prompt and only use that on the title, ensuring we have a default title set so no errors will show on initial save
dkotter
previously approved these changes
Nov 2, 2023
dkotter
approved these changes
Nov 2, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #587
Visuals
How to test the Change
Changelog Entry
Credits
Props @ravinderk, @iamdharmesh.
Checklist: