Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/586 New Filters #604

Merged
merged 12 commits into from
Oct 31, 2023
Merged

Enhancement/586 New Filters #604

merged 12 commits into from
Oct 31, 2023

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented Oct 24, 2023

Description of the Change

This PR adds new filters and a new (second) parameter to pass the feature name in the OpenAPI/APIRequest class. Also, fixed a few hook names in their doc comments.

  1. classifai_openai_api_request_get_url
  2. classifai_openai_api_request_get_options
  3. classifai_openai_api_response_get
  4. classifai_openai_api_request_post_url
  5. classifai_openai_api_request_post_options
  6. classifai_openai_api_response_post
  7. classifai_openai_api_request_post_form_url
  8. classifai_openai_api_request_post_form_options
  9. classifai_openai_api_response_post_form
  10. classifai_openai_characters_in_token
  11. classifai_openai_tokens_per_word

Closes #586

How to test the Change

By using any of the new filters and see if it works.

Changelog Entry

Added - New filters
Added - Second parameter in the OpenAPI/APIRequest class
Fixed - A few hook names in their doc comments.

Credits

Props @jeffpaul @dkotter @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi added the type:enhancement New feature or request. label Oct 24, 2023
@faisal-alvi faisal-alvi added this to the 2.4.0 milestone Oct 24, 2023
@faisal-alvi faisal-alvi self-assigned this Oct 24, 2023
@faisal-alvi faisal-alvi requested review from dkotter, jeffpaul and a team as code owners October 24, 2023 10:03
@faisal-alvi faisal-alvi removed the request for review from a team October 24, 2023 10:04
@dkotter dkotter requested a review from berkod October 25, 2023 17:08
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this was reviewed in UAT today and approved for merge

@jeffpaul jeffpaul merged commit 3913d61 into develop Oct 31, 2023
13 checks passed
@jeffpaul jeffpaul deleted the enhancement/586 branch October 31, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt and payload filter standardization
4 participants