Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from DALL·E 2 to DALL·E 3 #717

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Upgrade from DALL·E 2 to DALL·E 3 #717

merged 7 commits into from
Feb 21, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 14, 2024

Description of the Change

We currently utilize DALL·E 2 in our Image Generation Feature. OpenAI released DALL·E 3 to the public last fall and so this PR updates our integration to use DALL·E 3.

I had originally considered having an option to choose between the two models, as DALL·E 2 is still available and is cheaper but there are new options that only apply to DALL·E 3, making it harder to support both, and the quality of generated images is so much better with DALL·E 3 that it seemed the right idea to only support that.

How to test the Change

  1. Go to Tools > ClassifAI > Image Processing > Image Generation
  2. Turn on the Feature and enter a valid API key
  3. Change any other settings as desired
  4. Go to the stand-alone image generation page by going to Media > Generate Image
  5. Enter in a prompt and ensure images are generated
  6. Create a new post and add an Image block. Go to the Media Library of the Image block and go to the Generate Images tab
  7. Enter in a prompt and ensure images are generated

Changelog Entry

Changed - Upgrade from DALL·E 2 to DALL·E 3 in our Image Generation Feature

Credits

Props @dkotter, @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 3.0.0 milestone Feb 14, 2024
@dkotter dkotter self-assigned this Feb 14, 2024
@dkotter dkotter requested review from jeffpaul and a team as code owners February 14, 2024 22:27
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 14, 2024
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful in the setup/settings display of the Image size options to perhaps add a parenthetical descriptor for each whether the dimensions are (square), (landscape), or (portrait) to help clarify how each size will effectively render.

I also think there's a small enhancement on the Generate images modal to include the Number of images, Image quality, Image size, and Image style with each preset to its site-wide default but allow someone to tweak per that specific image generation request?

@dkotter
Copy link
Collaborator Author

dkotter commented Feb 15, 2024

Would be helpful in the setup/settings display of the Image size options to perhaps add a parenthetical descriptor for each whether the dimensions are (square), (landscape), or (portrait) to help clarify how each size will effectively render.

Good idea, I've added this

I also think there's a small enhancement on the Generate images modal to include the Number of images, Image quality, Image size, and Image style with each preset to its site-wide default but allow someone to tweak per that specific image generation request?

One thing to consider is that the number of images, image quality and image size are all options that impact the price, so I think we would need the ability to not allow those to be changed at the Image Generation level. But yes, I agree that having the option to show those would be a nice enhancement though may be better handled in a follow up PR.

@dkotter dkotter mentioned this pull request Feb 20, 2024
19 tasks
@github-actions github-actions bot added the needs:refresh This requires a refreshed PR to resolve. label Feb 21, 2024
@github-actions github-actions bot removed the needs:refresh This requires a refreshed PR to resolve. label Feb 21, 2024
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dkotter dkotter merged commit 8c140f5 into develop Feb 21, 2024
11 of 13 checks passed
@dkotter dkotter deleted the feature/dalle3 branch February 21, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants