Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "type": "wordpress-plugin", to the composer.json file #80

Closed
joshuaabenazer opened this issue Mar 8, 2018 · 1 comment
Closed

Add "type": "wordpress-plugin", to the composer.json file #80

joshuaabenazer opened this issue Mar 8, 2018 · 1 comment
Assignees
@joshuaabenazer @tlovett1

Comments

@joshuaabenazer
Copy link
Contributor

Wanted to see if there are any reasons we would not like to specify that in the composer.json.
This makes it easy for other projects using the plugin as a dependency in their composer.json file. Currently it goes to the vendor directory by default.
@tlovett1
Copy link
Member

tlovett1 commented Mar 8, 2018 •
edited

Great idea. Can you open a PR?

@joshuaabenazer joshuaabenazer self-assigned this Mar 8, 2018
joshuaabenazer added a commit that referenced this issue Mar 8, 2018
@joshuaabenazer
Add type attribute to composer.json to specify the plugin get's insta…
c99beee 
…lled in the plugins folder for WP. Handles #80
@joshuaabenazer joshuaabenazer mentioned this issue Mar 8, 2018
Merged
@tlovett1 tlovett1 closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaabenazer joshuaabenazer

@tlovett1 tlovett1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuaabenazer @tlovett1